IBX-10932: Changed back to top btn hover effect & text visibility #1766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR changes the back-to-top button's text display behavior from scroll-position-based to hover-based interaction. Instead of showing the button text only when scrolled to the bottom of the page, the text now appears when users hover over the button.
Key changes:
- Replaced scroll-based text visibility logic with CSS hover effect
- Removed JavaScript code that calculated scroll position to toggle text visibility
- Simplified function naming to reflect new behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/bundle/Resources/public/scss/_back-to-top.scss | Added hover state to show title text; removed scroll-based visibility modifier class |
| src/bundle/Resources/public/js/scripts/admin.back.to.top.js | Removed scroll position calculation logic and text visibility toggling; renamed function to reflect simplified behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GrabowskiM
approved these changes
Nov 7, 2025
dew326
approved these changes
Nov 13, 2025
RopRaptor
approved these changes
Nov 13, 2025
GrabowskiM
approved these changes
Nov 13, 2025
Contributor
|
QA Approved on DXP Commerce 4.6.x-dev |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
For QA:
Documentation: