[Behat] IBX-6335: Added PropertiesList component #898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katarzynazawada
requested review from
bogusez,
jwibexa,
micszo,
mnocon and
tomaszszopinski
mnocon
reviewed
Sep 7, 2023
Contributor
mnocon
left a comment
mnocon
left a comment
There was a problem hiding this comment.
Looking good, thanks for adding this component! Just one remark from me
| $this->getHTMLPage()->find($this->getLocator('tabContent'))->assert()->isVisible(); | ||
| } | ||
|
|
||
| public function verifyValue(string $label, string $value): void |
Contributor
There was a problem hiding this comment.
This is a better name than the one I came up with 😄 💪
| protected function specifyLocators(): array | ||
| { | ||
| return [ | ||
| new VisibleCSSLocator('tabContent', 'ibexa-tab-content'), |
Contributor
There was a problem hiding this comment.
I don't think this is a valid CSS selector (I guess a dot is missing) - which makes me thing that the verifyIsLoaded method is never called
tomaszszopinski
approved these changes
Sep 7, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
bogusez
approved these changes
Sep 7, 2023
mnocon
approved these changes
Sep 7, 2023
micszo
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.ibexa.co/browse/IBX-6335
This PR adds PropertiesList component to verify value of fields in content tabs.