Skip to content

Fixed deprecation notices in string interpolation with PHP 8.2 #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2023
Merged

Fixed deprecation notices in string interpolation with PHP 8.2 #205

merged 1 commit into from
Feb 16, 2023

Conversation

@patrickallaert
Copy link
Contributor

@patrickallaert patrickallaert commented Feb 13, 2023 •
edited
Loading

Question Answer
JIRA issue
Type improvement
Target Ibexa version v4.3
BC breaks no

Fixes new PHP 8.2 deprecation notices:
Deprecated: Using ${var} in strings is deprecated, use {$var} instead in ...

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

konradoboza
konradoboza approved these changes Feb 14, 2023
View reviewed changes
@konradoboza konradoboza requested a review from alongosz February 14, 2023 09:16
@patrickallaert patrickallaert changed the title Fixed: Deprecation notices in string interpolation with PHP 8.2 Fixed deprecation notices in string interpolation with PHP 8.2 Feb 15, 2023
@alongosz alongosz merged commit 4ae7334 into ibexa:4.3 Feb 16, 2023
@alongosz
Copy link
Member

alongosz commented Feb 16, 2023

Thank you @patrickallaert 🎉

@adriendupuis adriendupuis mentioned this pull request Mar 30, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@konradoboza konradoboza konradoboza approved these changes

@alongosz alongosz alongosz approved these changes

+1 more reviewer

@kisztof kisztof kisztof approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adamwojs adamwojs

@mikadamczyk mikadamczyk

@Steveb-p Steveb-p

@alongosz alongosz

@ciastektk ciastektk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@patrickallaert @alongosz @kisztof @konradoboza @adamwojs @mikadamczyk @Steveb-p @ciastektk