-
Couldn't load subscription status.
- Fork 17
Fixed PermissionResolver::canUser examples #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Could you please change branch to 4.5? In opposite to documentation repositories we are open PR against the lowest version when the given change is applicable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Target Ibexa version | v4.5+
@adriendupuis could you rebase it against 4.5 then please? :)
The 4th parameter must be an array according to signature (an array of ValueObject according to phpDoc)
b26d4bf to
78e6ce3
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thank you @adriendupuis 🎉 |








v4.5+The 4th parameter of
PermissionResolver::canUsemust be an array according to its signature, an array ofValueObjectaccording to its phpDoc.Tested with a controller extending
Ibexa\Core\MVC\Symfony\Controller\Controller:It ends with error "
Ibexa\Core\Repository\Permission\CachedPermissionService::canUser(): Argument #4 ($targets) must be of type array, Ibexa\Core\Repository\Values\Content\Location given"The following quick fix seems to work but I didn't have a proper limitation to go with it as I could just pass an empty array or random strings in the array:
It needs a more proper/advanced test by someone else than me 😓
See ibexa/documentation-developer#2132 for doc counter-part.
Checklist:
$ composer fix-cs).@ibexa/engineering).