IBX-8558: Removed GuardRepositoryAuthenticationProvider due to Symfony security deprecations

phpstan-baseline.neon

@@ -46970,31 +46970,6 @@ parameters:
 			count: 1
 			path: tests/lib/MVC/Symfony/Routing/UrlAliasRouterTest.php
 
-		-
-			message: "#^Call to an undefined method Symfony\\\\Component\\\\Security\\\\Core\\\\Authentication\\\\Token\\\\TokenInterface\\:\\:getProviderKey\\(\\)\\.$#"
-			count: 1
-			path: tests/lib/MVC/Symfony/Security/Authentication/GuardRepositoryAuthenticationProviderTest.php
-
-		-
-			message: "#^Method Ibexa\\\\Tests\\\\Core\\\\MVC\\\\Symfony\\\\Security\\\\Authentication\\\\GuardRepositoryAuthenticationProviderTest\\:\\:testAuthenticate\\(\\) has no return type specified\\.$#"
-			count: 1
-			path: tests/lib/MVC/Symfony/Security/Authentication/GuardRepositoryAuthenticationProviderTest.php
-
-		-
-			message: "#^Method Ibexa\\\\Tests\\\\Core\\\\MVC\\\\Symfony\\\\Security\\\\Authentication\\\\GuardRepositoryAuthenticationProviderTest\\:\\:testAuthenticateUnsupportedToken\\(\\) has no return type specified\\.$#"
-			count: 1
-			path: tests/lib/MVC/Symfony/Security/Authentication/GuardRepositoryAuthenticationProviderTest.php
-
-		-
-			message: "#^Method Ibexa\\\\Tests\\\\Core\\\\MVC\\\\Symfony\\\\Security\\\\Authentication\\\\GuardRepositoryAuthenticationProviderTest\\:\\:testAuthenticateWrongGuardProviderKey\\(\\) has no return type specified\\.$#"
-			count: 1
-			path: tests/lib/MVC/Symfony/Security/Authentication/GuardRepositoryAuthenticationProviderTest.php
-
-		-
-			message: "#^Parameter \\#1 \\$token of method Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\Security\\\\Authentication\\\\GuardRepositoryAuthenticationProvider\\:\\:authenticate\\(\\) expects Symfony\\\\Component\\\\Security\\\\Guard\\\\Token\\\\GuardTokenInterface, PHPUnit\\\\Framework\\\\MockObject\\\\MockObject&Symfony\\\\Component\\\\Security\\\\Core\\\\Authentication\\\\Token\\\\AnonymousToken given\\.$#"
-			count: 1
-			path: tests/lib/MVC/Symfony/Security/Authentication/GuardRepositoryAuthenticationProviderTest.php
-
 		-
 			message: "#^Method Ibexa\\\\Tests\\\\Core\\\\MVC\\\\Symfony\\\\Security\\\\HttpUtilsTest\\:\\:checkRequestPathProvider\\(\\) has no return type specified\\.$#"
 			count: 1

src/bundle/Core/DependencyInjection/Compiler/SecurityPass.php

@@ -8,10 +8,8 @@
 
 namespace Ibexa\Bundle\Core\DependencyInjection\Compiler;
 
-use Ibexa\Contracts\Core\Repository\PermissionResolver;
 use Ibexa\Contracts\Core\SiteAccess\ConfigResolverInterface;
 use Ibexa\Core\MVC\Symfony\Security\Authentication\DefaultAuthenticationSuccessHandler;
-use Ibexa\Core\MVC\Symfony\Security\Authentication\GuardRepositoryAuthenticationProvider;
 use Ibexa\Core\MVC\Symfony\Security\HttpUtils;
 use Ibexa\Core\MVC\Symfony\SiteAccess;
 use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
@@ -26,21 +24,6 @@ final class SecurityPass implements CompilerPassInterface
 {
     public function process(ContainerBuilder $container): void
     {
-        if (
-            !$container->hasDefinition('security.authentication.provider.guard')
-        ) {
-            return;
-        }
-
-        $permissionResolverRef = new Reference(PermissionResolver::class);
-
-        $guardAuthenticationProviderDef = $container->findDefinition('security.authentication.provider.guard');
-        $guardAuthenticationProviderDef->setClass(GuardRepositoryAuthenticationProvider::class);
-        $guardAuthenticationProviderDef->addMethodCall(
-            'setPermissionResolver',
-            [$permissionResolverRef]
-        );
-
         if (!$container->hasDefinition('security.http_utils')) {
             return;
         }

tests/bundle/Core/DependencyInjection/Compiler/SecurityPassTest.php

@@ -41,11 +41,6 @@ public function testAlteredDaoAuthenticationProvider(): void
     {
         $this->compile();
 
-        $this->assertContainerBuilderHasServiceDefinitionWithMethodCall(
-            'security.authentication.provider.guard',
-            'setPermissionResolver',
-            [new Reference(PermissionResolver::class)]
-        );
         $this->assertContainerBuilderHasServiceDefinitionWithMethodCall(
             'security.http_utils',
             'setSiteAccess',

tests/integration/Core/Repository/SearchServiceImageTest.php

@@ -365,6 +365,11 @@ private function ensureImageFieldTypeIsSearchable(ContentType $contentType): voi
         );
     }
 
+    /**
+     * @throws \Ibexa\Contracts\Core\Repository\Exceptions\InvalidArgumentException
+     * @throws \Ibexa\Contracts\Core\Repository\Exceptions\BadStateException
+     * @throws \Ibexa\Contracts\Core\Repository\Exceptions\UnauthorizedException
+     */
     private function setFieldTypeAsSearchable(
         ContentTypeDraft $contentTypeDraft,
         FieldDefinition $fieldDefinition
@@ -379,5 +384,6 @@ private function setFieldTypeAsSearchable(
             $fieldDefinition,
             $fieldDefinitionUpdateStruct
         );
+        $contentTypeService->publishContentTypeDraft($contentTypeDraft);
     }
 }