Skip to content

[Tests] Truncated SQLite last insert ID to real DB integer value #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2024
Merged

[Tests] Truncated SQLite last insert ID to real DB integer value #421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/lib/Persistence/Legacy/SharedGateway/DatabasePlatform/SqliteGateway.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ final class SqliteGateway implements Gateway
*/
private const FATAL_ERROR_CODE = 7;

private const DB_INT_MAX = 2147483647;

/** @var array<string, int> */
private $lastInsertedIds = [];

Expand All @@ -27,7 +29,7 @@ public function getColumnNextIntegerValue(
string $sequenceName
): ?int {
$lastId = $this->lastInsertedIds[$sequenceName] ?? 0;
$nextId = (int)hrtime(true);
$nextId = (int)hrtime(true) % self::DB_INT_MAX;

// $lastId === $nextId shouldn't happen using high-resolution time, but better safe than sorry
return $this->lastInsertedIds[$sequenceName] = $lastId === $nextId ? $nextId + 1 : $nextId;
Expand Down