Add missing variable name in var tag in PermissionResolver #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Site note: that is now marked by PhpStorm: https://github.com/ibexa/core/pull/423/files#diff-5e84054a89c1fe76997fe0f96be6a9fcd4541af0814ce7c6ce0f1ded12fc3dc9R217 The return type is iterable, thus it can never be |
adamwojs
approved these changes
Aug 26, 2024
Member
|
@ms2ad Could you please change target branch to 4.6 ? |
ghost
changed the base branch from
Author
|
@adamwojs Done. |
ghost
closed this
Author
|
Sorry, the branch for this PR should not have been deleted. |
|
Member
|
Thank you @ms2ad! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Without the variable name, PhpStorm will not apply the
@varannotation to the loop variable.For QA:
Documentation: