[Composer] Dropped ibexa/ci-scripts from dev requirements #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
force-pushed
the
ibx-8470-drop-ci-scripts-from-reqs
branch
from
9d46fd7 to
629bef4
Compare
|
tbialcz
approved these changes
Oct 10, 2024
konradoboza
approved these changes
Oct 10, 2024
micszo
approved these changes
Oct 10, 2024
ciastektk
approved these changes
Oct 10, 2024
adamwojs
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR drops dev requirement on ibexa/ci-scripts introduced via ezsystems/ezplatform-kernel#173.
The idea there was to run regressions from any of the packages, therefore it was added there in core as a test.
After talking to @mnocon it seemed that this was not utilized in the end in favor of standalone CLI tool approach.
This dependency affects Symfony 6 upgrade as ci-scripts are a standalone Symfony console app and is used as so, instead of as a dependency. Meaning otherwise I'd have to upgrade that app first, which is a project on its own (probably not too complicated tho).
For QA:
This does not affect regressions as this is dev dependency. If CI passes, it's enough.