Skip to content

Conversation

@barw4
Copy link
Contributor

@barw4 barw4 commented Sep 23, 2025

🎫 Issue IBX-XXXXX

Description:

Aside from $container being nullable I don't think we can do much for the following:

        $location = new Location();
        $value = isset($location->notDefined);
        self::assertFalse($value);

        $value = isset($location->id);
        self::assertTrue($value);

which results in:

Property Ibexa\Contracts\Core\Repository\Values\Content\Location::$id (int) in isset() is not nullable.  
         🪪  isset.property

therefore I added these cases to baseline.

For QA:

Documentation:

@barw4 barw4 self-assigned this Sep 23, 2025
@barw4 barw4 added Bug Something isn't working Ready for review labels Sep 23, 2025
@barw4 barw4 requested a review from a team September 23, 2025 08:13
@ezrobot ezrobot requested review from Steveb-p, ViniTou, adamwojs, alongosz, ciastektk, konradoboza, mikadamczyk, tbialcz and wiewiurdp and removed request for a team September 23, 2025 08:14
@barw4 barw4 requested a review from Steveb-p September 23, 2025 08:48
@barw4 barw4 requested a review from konradoboza September 23, 2025 08:55
@sonarqubecloud
Copy link

@barw4 barw4 merged commit 2ba7fdf into 4.6 Sep 23, 2025
25 checks passed
@barw4 barw4 deleted the fix-phpstan-issues branch September 23, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Ready for MERGE

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants