Skip to content

IBX-10865 set correct type for Content-Length header #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2025
Merged

IBX-10865 set correct type for Content-Length header #671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2600abb
IBX-10865 set correct type for Content-Length header
papcio122 Oct 29, 2025
2c350fc
IBX-10865 update phpstan baseline
papcio122 Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4038,12 +4038,6 @@ parameters:
count: 1
path: src/bundle/IO/BinaryStreamResponse.php

-
message: '#^Parameter \#2 \$values of method Symfony\\Component\\HttpFoundation\\ResponseHeaderBag\:\:set\(\) expects array\<string\>\|string\|null, int given\.$#'
identifier: argument.type
count: 1
path: src/bundle/IO/BinaryStreamResponse.php

-
message: '#^Call to an undefined method Symfony\\Component\\Config\\Definition\\Builder\\NodeDefinition\:\:children\(\)\.$#'
identifier: method.notFound
Expand Down
2 changes: 1 addition & 1 deletion src/bundle/IO/BinaryStreamResponse.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ private function processRangeRequest(Request $request): void

$this->setStatusCode(Response::HTTP_PARTIAL_CONTENT);
$this->headers->set('Content-Range', sprintf('bytes %s-%s/%s', $start, $end, $fileSize));
$this->headers->set('Content-Length', $end - $start + 1);
$this->headers->set('Content-Length', (string)($end - $start + 1));
}
}
}
Expand Down
Loading