IBX-10937: Add the ContentTypeGroupName criterion for findContentTypes PAPI
#675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@barw4 Will you add the criterion to the REST API, too? |
Contributor
Author
yes, just after it's merged |
konradoboza
approved these changes
Nov 7, 2025
Steveb-p
reviewed
Nov 7, 2025
src/lib/Persistence/Legacy/Content/Type/Gateway/CriterionHandler/ContentTypeGroupName.php
Outdated
Show resolved
Hide resolved
| 'LOWER(ctg.name)', | ||
| $qb->createNamedParameter(array_map('strtolower', $criterion->getValue()), Connection::PARAM_STR_ARRAY) | ||
| ) : $subQuery->expr()->eq( | ||
| 'LOWER(ctg.name)', |
Contributor
There was a problem hiding this comment.
Warning
This does not make use of indexes, if any exist for name column.
Contributor
Author
There was a problem hiding this comment.
Noted, no index in name column though
|
Steveb-p
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The usage is:
For QA:
Documentation: