Skip to content

IBX-10936: Made ProxyDomainMapperFactory lazy #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: 4.6
Choose a base branch
from
Open

IBX-10936: Made ProxyDomainMapperFactory lazy #676

wants to merge 9 commits into from
+68 −147

Conversation

@barw4
Copy link
Contributor

@barw4 barw4 commented Nov 12, 2025 •
edited
Loading

🎫 Issue IBX-10936

Related PRs:

ibexa/admin-ui#1765

Description:

!! PHP Fatal error: Uncaught Error: Maximum call stack size of 16728064 bytes (zend.max_allowed_stack_size - zend.reserved_stack_size) reached. Infinite recursion? in /var/www/var/cache/behat/ContainerOxSk76G/App_KernelBehatDebugContainer.php:7048
!! Stack trace:
!! #0 /var/www/var/cache/behat/ContainerOxSk76G/App_KernelBehatDebugContainer.php(7104): ContainerOxSk76G\App_KernelBehatDebugContainer->getProxyDomainMapperService()
!! https://github.com/ibexa/admin-ui/pull/1 /var/www/var/cache/behat/ContainerOxSk76G/App_KernelBehatDebugContainer.php(7048): ContainerOxSk76G\App_KernelBehatDebugContainer->getRepositoryService()
!! https://github.com/ibexa/admin-ui/pull/2 /var/www/var/cache/behat/ContainerOxSk76G/App_KernelBehatDebugContainer.php(7104): ContainerOxSk76G\App_KernelBehatDebugContainer->getProxyDomainMapperService()
!! https://github.com/ibexa/admin-ui/pull/3 /var/www/var/cache/behat/ContainerOxSk76G/App_KernelBehatDebugContainer.php(7048): ContainerOxSk76G\App_KernelBehatDebugContainer->getRepositoryService()
!! https://github.com/ibexa/admin-ui/pull/4 /var/www/var/cache/behat/ContainerOxSk76G/App_KernelBehatDebugContainer.php(7104): ContainerOxSk76G\App_KernelBehatDebugContainer->getProxyDomainMapperService()
!! https://github.com/ibexa/admin-ui/pull/5 /var/www/var/cache/behat/ContainerOxSk76G/App_KernelBehatDebugContainer.php(7048): ContainerOxSk76G\App_KernelBehatDebugContainer->getRepositoryService()

Circular reference is between Repository and ProxyDomainMapperService.

Additionally PHPStan issue were cleared.

For QA:

Sanities

Documentation:

@barw4 barw4 mentioned this pull request Nov 12, 2025
Open
Steveb-p
Steveb-p reviewed Nov 12, 2025
View reviewed changes
@barw4 barw4 added Bug Something isn't working Ready for review labels Nov 12, 2025
@barw4 barw4 requested review from a team and Steveb-p November 13, 2025 08:46
Steveb-p
Steveb-p approved these changes Nov 13, 2025
View reviewed changes
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was surprised that PSR Cache exception interface did not mark itself as extending throwable, but apparently they did this to support PHP 5.6+.

@Steveb-p Steveb-p requested a review from a team November 13, 2025 08:52
konradoboza
konradoboza approved these changes Nov 13, 2025
View reviewed changes
Copy link
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it targets 4.6 we need to perform sanities (or at least regressions) before merging.

alongosz
alongosz reviewed Nov 13, 2025
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 13, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

@alongosz alongosz alongosz approved these changes

@ViniTou ViniTou ViniTou approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@mikadamczyk mikadamczyk

@alongosz alongosz

@tischsoic tischsoic

Labels

Bug Something isn't working Ready for QA

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@barw4 @Steveb-p @alongosz @ViniTou @konradoboza @mikadamczyk @tischsoic