Remove ¶ while displaying search results #1590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The permalink character `¶` is extracted and indexed by the crawler. To ensure that it always removed when displaying search results, it can be done with `docsearch` `transformData` https://docsearch.algolia.com/docs/legacy/behavior/#transformdata
adriendupuis
commented
Apr 19, 2022
adriendupuis
commented
Apr 19, 2022
docs/js/custom.js
Outdated
| $.each(hits, function(index, hit) { | ||
| for (lvl=2; lvl<=3; lvl++) { | ||
| if (null !== hit.hierarchy['lvl'+lvl]) { | ||
| hits[index].hierarchy['lvl' + lvl] = hit.hierarchy['lvl' + lvl].replace(/[.¶]/g, ''); |
There was a problem hiding this comment.
I didn't find where this is used. _highlightResult.hierarchy is the one used to build the dropdown result menu.
damianz5
approved these changes
Apr 19, 2022
adriendupuis
commented
Apr 19, 2022
|
Some examples to test:
|
adriendupuis
added a commit
that referenced
this pull request
Apr 19, 2022
(cherry picked from commit 23f5bf2)
adriendupuis
added a commit
that referenced
this pull request
Apr 19, 2022
(cherry picked from commit 23f5bf2)
adriendupuis
added a commit
that referenced
this pull request
Apr 19, 2022
(cherry picked from commit 23f5bf2)
adriendupuis
added a commit
that referenced
this pull request
Apr 19, 2022
(cherry picked from commit 23f5bf2)
|
Cherry-picked to 4.1, 4.0, 3.3, 2.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The permalink character
¶is extracted and indexed by the crawler.Actually, it is shown in search results on https://doc.ibexa.co/en/4.1/ while not shown on https://doc.ibexa.co/en/3.3/ which is still an enigma to me while opening this PR.
To ensure that it's always removed when displaying search results, it can be done while building the dropdown using DocSearch v2's
transformDatafeature.