Java requirements upgrade #1601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Further recommendation according to https://developers.ibexa.co/security-advisories/cve-2021-44228-log4j-vulnerability
adamwojs
approved these changes
Apr 27, 2022
juskora
approved these changes
May 5, 2022
Co-authored-by: Justyna Koralewicz <79849375+juskora@users.noreply.github.com>
Co-authored-by: Justyna Koralewicz <79849375+juskora@users.noreply.github.com>
glye
commented
May 6, 2022
|
Applied last suggested changes. |
|
@adamwojs @nkostiv @JavaSaBr @kaborkowski Hi! As java devs, do you agree with the requirements upgrades? |
Yes |
juskora
added a commit
that referenced
this pull request
May 11, 2022
* Upgrade requirements for Java dependencies * Upper bound for Java * Log4j updates Further recommendation according to https://developers.ibexa.co/security-advisories/cve-2021-44228-log4j-vulnerability * Update docs/getting_started/requirements.md Co-authored-by: Justyna Koralewicz <79849375+juskora@users.noreply.github.com> * Update docs/getting_started/requirements.md Co-authored-by: Justyna Koralewicz <79849375+juskora@users.noreply.github.com> * Update docs/getting_started/requirements.md Co-authored-by: Justyna Koralewicz <79849375+juskora@users.noreply.github.com>
juskora
added a commit
that referenced
this pull request
May 11, 2022
* Upgrade requirements for Java dependencies * Upper bound for Java * Log4j updates Further recommendation according to https://developers.ibexa.co/security-advisories/cve-2021-44228-log4j-vulnerability * Update docs/getting_started/requirements.md Co-authored-by: Justyna Koralewicz <79849375+juskora@users.noreply.github.com> * Update docs/getting_started/requirements.md Co-authored-by: Justyna Koralewicz <79849375+juskora@users.noreply.github.com> * Update docs/getting_started/requirements.md Co-authored-by: Justyna Koralewicz <79849375+juskora@users.noreply.github.com>
juskora
added a commit
that referenced
this pull request
May 11, 2022
* Upgrade requirements for Java dependencies * Upper bound for Java * Log4j updates Further recommendation according to https://developers.ibexa.co/security-advisories/cve-2021-44228-log4j-vulnerability * Update docs/getting_started/requirements.md Co-authored-by: Justyna Koralewicz <79849375+juskora@users.noreply.github.com> * Update docs/getting_started/requirements.md Co-authored-by: Justyna Koralewicz <79849375+juskora@users.noreply.github.com> * Update docs/getting_started/requirements.md Co-authored-by: Justyna Koralewicz <79849375+juskora@users.noreply.github.com>
juskora
added a commit
that referenced
this pull request
May 11, 2022
* Upgrade requirements for Java dependencies * Upper bound for Java * Log4j updates Further recommendation according to https://developers.ibexa.co/security-advisories/cve-2021-44228-log4j-vulnerability * Update docs/getting_started/requirements.md Co-authored-by: Justyna Koralewicz <79849375+juskora@users.noreply.github.com> * Update docs/getting_started/requirements.md Co-authored-by: Justyna Koralewicz <79849375+juskora@users.noreply.github.com> * Update docs/getting_started/requirements.md Co-authored-by: Justyna Koralewicz <79849375+juskora@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade requirements, add recommendations, add Tika info.
Ref discussion at https://ibexa.slack.com/archives/G01JCT44S3B/p1651049120622749
We require Java 8. The Log4j / Log4shell security issue affected only Java 8, not newer releases. Java 8 is from 2014. Oracle ended premier support this March, but it's on extended support until 2030.
Java 11 LTS has Oracle premier support until September 2023. Java 17 LTS until 2026.
Afaik we don't support the newer 17(?) and 21 Java LTS releases yet, so we should set an upper bound as well. Correct?
https://www.oracle.com/java/technologies/java-se-support-roadmap.html
Tika was not mentioned here before. I took the 1.20 requirement from here, and added a recommendation for 1.28.1 or higher, due to security related upgrades in that release. We need to verify if this is a valid recommendation.
https://dist.apache.org/repos/dist/release/tika/1.28.1/CHANGES-1.28.1.txt
Maybe consider to replace the version specifications in https://doc.ibexa.co/en/latest/guide/file_management/#enable-binaryfile-field-indexing with a pointer to the requirements page, to avoid maintaing this info several places.