IBX-6878: Customize search sorting #2226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriendupuis
commented
Nov 21, 2023
...back_office/search/src/Search/SortingDefinition/Provider/RandomSortingDefinitionProvider.php
Outdated
Show resolved
Hide resolved
SortClause\CustomField is not covered by legacy search engine and may differ from Solr to Elasticsearch
adamwojs
approved these changes
Dec 1, 2023
Member
adamwojs
left a comment
adamwojs
left a comment
There was a problem hiding this comment.
Some minor comments, but overall good job 💪
...office/search/src/Search/SortingDefinition/Provider/SectionNameSortingDefinitionProvider.php
Outdated
Show resolved
Hide resolved
...office/search/src/Search/SortingDefinition/Provider/SectionNameSortingDefinitionProvider.php
Outdated
Show resolved
Hide resolved
...office/search/src/Search/SortingDefinition/Provider/SectionNameSortingDefinitionProvider.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Adam Wójs <adam@wojs.pl>
adriendupuis
commented
Dec 19, 2023
julitafalcondusza
requested changes
Feb 28, 2024
Contributor
julitafalcondusza
left a comment
julitafalcondusza
left a comment
There was a problem hiding this comment.
See my comments.
Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com>
julitafalcondusza
requested changes
Mar 4, 2024
Contributor
julitafalcondusza
left a comment
julitafalcondusza
left a comment
There was a problem hiding this comment.
Please check my comments.
julitafalcondusza
approved these changes
Mar 5, 2024
dabrt
requested changes
Mar 25, 2024
Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com>
adriendupuis
added
Ready for MERGE
and removed
Needs DOC review
Needs DEV review
labels
Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>
mnocon
approved these changes
Apr 18, 2024
# Conflicts: # code_samples/back_office/search/config/append_to_services.yaml # mkdocs.yml
adriendupuis
added a commit
that referenced
this pull request
Apr 19, 2024
--------- Co-authored-by: Adrien Dupuis <adrien.dupuis@ibexa.co> Co-authored-by: Adam Wójs <adam@wojs.pl> Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com> Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com> (cherry picked from commit 9d37154)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to customize Back Office search result page's "Sort by" drop-down menu.
Install and run example:
Go to search page (e.g. http://localhost/admin/search?search%5Bquery%5D=user), open the sorting menu, see the "Sort by section" options.
Checklist