Update and fix REST Ref #2368
Merged
Update and fix REST Ref #2368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The route is `/payment-method` not `/payment-method/` https://github.com/ibexa/payment/blob/v4.6.3/src/bundle/Resources/config/routing_rest.yaml#L50-L51
yaml_parse_file(): scanning error encountered during parsing: mapping values are not allowed in this context (line 73, column 98)
adriendupuis
referenced
this pull request
Apr 23, 2024
GET doesn't need an Content-Type header as there is no payload to type. Add some missing Accept headers
- EntryUpdateStruct is the PHP class - CartEntryUpdate is the REST Content-Type https://github.com/ibexa/cart/blob/main/src/bundle/REST/Input/Parser/CartEntryUpdate.php
Found no trace of a CatalogGet parser
ContentCreateStruct is a PHP class invisible from REST abstraction. https://github.com/ibexa/rest/blob/v4.6.3/src/lib/Server/Input/Parser/ContentCreate.php#L177 See https://github.com/ibexa/rest/blob/v4.6.3/tests/lib/Server/Input/Parser/ContentCreateTest.php#L27 for an usage example.
Contributor
Author
|
There is still a lot of checks to do in
I just won't do it now. The 57 unused types:
(See #1901 |
Contributor
Author
|
It lacks or review but I’m self-confident enough to merge it. It can be fixed latter if needed. |
adriendupuis
added a commit
that referenced
this pull request
Jun 6, 2024
(cherry picked from commit 0b22caf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/segments' and/segment_groups'GETroutesDELETE /shipments/{identifier}/payment-method/→/payment-methodObjectStateGroupUpdatebody's indent.AcceptorContent-Typeheaders.Content-Typeheader from "GETwithout payload" routes.Acceptheaders.<FieldDefinitions media-type="application/vnd.ibexa.api.FieldDefinitionList+xml" href="/api/ibexa/v2/content/types/1/fieldDefinitions">where tag and media-type don't match.Preview: https://ez-systems-developer-documentation--2368.com.readthedocs.build/en/2368/api/rest_api/rest_api_reference/rest_api_reference.html
Checklist