-
Notifications
You must be signed in to change notification settings - Fork 82
PHP API Ref enhancement (June first batch) #2396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriendupuis
commented
Jun 7, 2024
tools/php_api_ref/.phpdoc/template/components/method-arguments.html.twig
Outdated
Show resolved
Hide resolved
# Conflicts: # docs/api/php_api/php_api_reference/classes/Ibexa-Contracts-Calendar-DateRange.html # docs/api/php_api/php_api_reference/classes/Ibexa-Contracts-Calendar-EventCollection.html # docs/api/php_api/php_api_reference/classes/Ibexa-Contracts-Calendar-EventGroup.html # docs/api/php_api/php_api_reference/classes/Ibexa-Contracts-Calendar-EventList.html # docs/api/php_api/php_api_reference/classes/Ibexa-Contracts-Core-Repository-Decorator-LocationServiceDecorator.html # docs/api/php_api/php_api_reference/classes/Ibexa-Contracts-Core-Repository-LocationService.html # docs/api/php_api/php_api_reference/classes/Ibexa-Contracts-Rest-Input-ParsingDispatcher.html
# Conflicts: # docs/api/php_api/php_api_reference/classes/Ibexa-Contracts-Calendar-DateRange.html # docs/api/php_api/php_api_reference/classes/Ibexa-Contracts-Calendar-EventAction-EventActionCollection.html # docs/api/php_api/php_api_reference/classes/Ibexa-Contracts-Calendar-EventCollection.html # docs/api/php_api/php_api_reference/classes/Ibexa-Contracts-Calendar-EventGroup.html # docs/api/php_api/php_api_reference/classes/Ibexa-Contracts-Calendar-EventList.html # docs/api/php_api/php_api_reference/classes/Ibexa-Contracts-Calendar-EventQueryBuilder.html # docs/api/php_api/php_api_reference/classes/Ibexa-Contracts-Calendar-EventSource-InMemoryEventSource.html # docs/api/php_api/php_api_reference/classes/Ibexa-Contracts-Core-Event-Mapper-ResolveMissingFieldEvent.html # docs/api/php_api/php_api_reference/classes/Ibexa-Contracts-Core-FieldType-DefaultDataFieldStorage.html # docs/api/php_api/php_api_reference/classes/Ibexa-Contracts-Core-Repository-Decorator-LocationServiceDecorator.html # docs/api/php_api/php_api_reference/classes/Ibexa-Contracts-Core-Repository-LocationService.html # docs/api/php_api/php_api_reference/classes/Ibexa-Contracts-Rest-Input-ParsingDispatcher.html
8053f7f to
32c5360
Compare
mnocon
approved these changes
Jun 17, 2024
Contributor
mnocon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went over the changes locally (skipping the autogenerated ones) and I think they make sense 💪
Thank you for providing this detailed description (with comparisons), without it it would be very hard to review this
adriendupuis
added a commit
that referenced
this pull request
Jun 17, 2024
(cherry picked from commit 2c7e620)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enhance or fix few PHP API Reference's templates.
components/interface-title.html.twig: Fix FQCNcomponents/method-arguments.html.twig:-instead ofNonein empty "Default value" col.-in empty "Description" col.emptyCSS class assignment to empty col.components/method-response.html.twig: Remove the "—" separation between response type and response description.components/tags.html.twig: Hidefinaltag.base.css.twig:Notes:
Comparison between old current and new preview
ActivityLogServiceInterface:ActivityLogServiceInterfaceCopy FQCN =Ibexa\Contracts\ActivityLogActivityLogServiceInterfaceCopy FQCN =Ibexa\Contracts\ActivityLog\ActivityLogServiceInterfaceMemberService::getCompanyMembers()MemberService::getCompanyMembers()DateRange::__construct()DateRange::__construct()Checklist