Fix bazinga usage #2500
Merged
Fix bazinga usage #2500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriendupuis
commented
Sep 23, 2024
docs/administration/project_organization/project_organization.md
Outdated
Show resolved
Hide resolved
adriendupuis
commented
Sep 23, 2024
bazinga must generate the translations in the ./public/assets directory, not the ./assets directory. See composer.json script using `bazinga:js-translation:dump %PUBLIC_DIR%/assets --merge-domains` https://github.com/ibexa/recipes/blob/master/ibexa/oss/4.6/manifest.json#L94
adriendupuis
force-pushed
the
assets-translations
branch
from
19a275b to
dfada0b
Compare
adriendupuis
commented
Nov 20, 2024
adriendupuis
commented
Nov 20, 2024
lionelakpagni
approved these changes
Nov 21, 2024
# Conflicts: # docs/administration/project_organization/project_organization.md # docs/multisite/languages/back_office_translations.md
mikadamczyk
approved these changes
Dec 12, 2024
dabrt
reviewed
Dec 12, 2024
mnocon
reviewed
Dec 12, 2024
Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com> Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>
Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com>
mnocon
approved these changes
Dec 12, 2024
adriendupuis
commented
Dec 12, 2024
adriendupuis
commented
Dec 12, 2024
adriendupuis
commented
Dec 12, 2024
dabrt
approved these changes
Dec 12, 2024
adriendupuis
commented
Dec 12, 2024
adriendupuis
added a commit
that referenced
this pull request
Dec 12, 2024
(cherry picked from commit 800daf9)
adriendupuis
added a commit
that referenced
this pull request
Dec 12, 2024
(cherry picked from commit 800daf9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bazingamust generate the translations in the./public/assetsdirectory, not the./assetsdirectory.It also means that removing
./assetsdoesn't remove translations.composer run post-update-cmdis clearing the cache, and is runningbazingaandyarn. It's the best way to get the translations working. As it clears only the default SiteAccess cache, the Back Office SiteAccess cache may need to be cleared as well.See
composer.jsonscript usingbazinga:js-translation:dump %PUBLIC_DIR%/assets --merge-domainsin 4.6'smanifest.json, or 3.3.15 update doc, or 4.0 update doc.Previews:
assetsmanually" foldable box. (side note, this box state is inherited from 3.0 moving to Symfony 4)Nota bene: This PR focus on
bazinga. https://ez-systems-developer-documentation--2500.com.readthedocs.build/en/2500/administration/project_organization/project_organization/#assets remaining part sounds wrong as Encore is supposed to be used, and "for example assets/js/script.js can be referenced as js/script.js from templates" doesn't make any sens. It's kept for another time and another PR about assets.Checklist