IBX-9415: Support for ContentAwareInterface in ibexa_* Twig functions described in Developer Documentation #2638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiewiurdp
approved these changes
Feb 27, 2025
mnocon
reviewed
Mar 3, 2025
There was a problem hiding this comment.
Your changes look good, thank you!
I have two suggestions:
- Please remove ContentInfo mentions where they are not supported
- Can you please adjust code sample include lines so that the
html+twigis not visible in theImage Twig functionssection (and the example is complete)? It's not part of your changes, but small enough that IMHO not worth a separate PR.
docs/templating/twig_function_reference/content_twig_functions.md
Outdated
Show resolved
Hide resolved
docs/templating/twig_function_reference/content_twig_functions.md
Outdated
Show resolved
Hide resolved
docs/templating/twig_function_reference/field_twig_functions.md
Outdated
Show resolved
Hide resolved
dabrt
approved these changes
Mar 4, 2025
julitafalcondusza
added a commit
that referenced
this pull request
Mar 5, 2025
… described in Developer Documentation (#2638) * contentaware support added * fixes * full namespaces removed * Fixes ater review * Description fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for ContentAwareInterface in ibexa_* Twig functions described in Developer Documentation.
Checklist