Skip to content

Conversation

@mnocon
Copy link
Contributor

@mnocon mnocon commented Apr 7, 2025

Target: master, 4.6

This feels very hacky to me - but on the other hand, we won't be changing the 4.6.0 release notes that often...

@mnocon mnocon marked this pull request as ready for review April 7, 2025 08:02
@github-actions
Copy link

github-actions bot commented Apr 7, 2025

Preview of modified Markdown:

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

docs/snippets/release_46.md:11

  • The conditional may lead to inconsistent behavior since the static update instructions link in the release notes file is always displayed. Consider reviewing if the update instructions should be conditionally rendered in both places for consistency.
[[% if version != 'v4.6.0' %]]

docs/release_notes/ibexa_dxp_v4.6.md:1101

  • Ensure that the update instructions link here aligns with the conditional logic in the snippet file to avoid any potential mismatch in user guidance.
To update your application, see the [update instructions](update_from_4.6.md).

@mnocon mnocon requested a review from adriendupuis April 7, 2025 11:04
@mnocon mnocon merged commit 19e1820 into master Apr 14, 2025
7 checks passed
@mnocon mnocon deleted the fix-broken-anchor branch April 14, 2025 07:08
@adriendupuis adriendupuis mentioned this pull request Apr 14, 2025
7 tasks
adriendupuis pushed a commit that referenced this pull request Apr 14, 2025
(cherry picked from commit 19e1820)
mnocon added a commit that referenced this pull request Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants