Skip to content

IBX-5808 - Improve "Products" to remove ambiguity #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 1, 2023
Merged

IBX-5808 - Improve "Products" to remove ambiguity #248

merged 4 commits into from
Dec 1, 2023

Conversation

@dabrt
Copy link
Contributor

@dabrt dabrt commented Nov 28, 2023 •
edited
Loading

Question Answer
JIRA Ticket IBX-5808
Versions 4.5 and up
Edition all

Updated the Product Completeness screenshot in "Products" article.
Restructured the unorganized PIM area in the process:

  • singled out product types,
  • explained what is necessary to make products saleable, etc.

This PR is related to 2232

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Added link to this PR in relevant JIRA ticket or code PR

@dabrt dabrt mentioned this pull request Nov 28, 2023
Merged
4 tasks
julitafalcondusza
julitafalcondusza requested changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@julitafalcondusza julitafalcondusza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments.

dabrt and others added 2 commits November 29, 2023 18:50
@dabrt
Implement reviewer comments
a6b0874
@dabrt @julitafalcondusza
Apply suggestions from code review
70ae9d3 
Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com>
juskora
juskora approved these changes Nov 30, 2023
View reviewed changes
dabrt
dabrt commented Dec 1, 2023
View reviewed changes
dabrt
dabrt commented Dec 1, 2023
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dabrt dabrt merged commit 65b63f3 into master Dec 1, 2023
@dabrt dabrt deleted the IBX-5808 branch December 1, 2023 10:29
dabrt added a commit that referenced this pull request Dec 1, 2023
@dabrt @julitafalcondusza
IBX-5808 - Improve "Products" to remove ambiguity (#248)
86f5f18 
* IBX-5808 - Improve "Enable purchasing products" to remove ambiguity

---------

Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com>
dabrt added a commit that referenced this pull request Dec 22, 2023
@dabrt
Revert "IBX-5808 - Improve "Products" to remove ambiguity (#248)"
85e734c 
This reverts commit 86f5f18.
dabrt added a commit that referenced this pull request Jan 5, 2024
@dabrt
IBX-5808 - Improve "Products" to remove ambiguity (#248)
4031b50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juskora juskora juskora approved these changes

@julitafalcondusza julitafalcondusza julitafalcondusza approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dabrt @juskora @julitafalcondusza