IBX-4064: Fix search page nav #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probably a copy-paste error when adapting dev doc's one.
- Fix first page link icon - hide "last page" link (this is not even the last page)
- Fix first page link icon - hide "last page" link (this is not even the last page)
|
Preview of modified Markdown: no Markdown change to preview. |
5 tasks
7 tasks
|
mnocon
approved these changes
Mar 13, 2025
adriendupuis
added a commit
that referenced
this pull request
Mar 13, 2025
* rm docs/css/instantsearch.js
* instantsearch.js: Fix navigation
- Fix first page link icon
- hide "last page" link (this is sometimes not even the last page)
* instantsearch.css: don't highlight last clicked prev/next button
(cherry picked from commit 22cdddd)
adriendupuis
added a commit
that referenced
this pull request
Mar 13, 2025
* rm docs/css/instantsearch.js
* instantsearch.js: Fix navigation
- Fix first page link icon
- hide "last page" link (this is sometimes not even the last page)
* instantsearch.css: don't highlight last clicked prev/next button
(cherry picked from commit 22cdddd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/persona_paths/icons.mdas they don't adapt well, (for example, they don't accept the color). If needed, it could be asked to design team to fix them.docs/css/instantsearch.jswas introduced in IBX-4064: Search page #322 and duplicatesdocs/js/instantsearch.js; It was probably a paste error while copying dev doc's one.Before
After
Checklist