Added cast to int when trying to load a location in Location redirect controller
#200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
changed the title
|
alongosz
changed the title
int when trying to load a location in Location redirect controller
alongosz
requested review from
Steveb-p,
ViniTou,
adamwojs,
barw4,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
konradoboza
approved these changes
Sep 17, 2025
mikadamczyk
approved these changes
Sep 17, 2025
Steveb-p
approved these changes
Sep 17, 2025
ciastektk
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
New day, new PHPStan release. Uncovered a potentially fatal error when strict types are enforced in Location redirect controller. Visible on 5.0.x-dev, but exists on 4.6. Seems for some reason on 5.0.x-dev the issue was not detected after refactoring controllers.
Fixed on 4.6 instead of re-adding to the baseline on main.