E2e updates #489
Merged
E2e updates #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
landonreed
reviewed
Sep 24, 2019
__tests__/test-utils/setup-e2e.js
Outdated
| } = require('./utils') | ||
|
|
||
| const serverJarFilename = 'dt-latest-dev.jar' | ||
| const serverJarFilename = 'dt-v3.2.0-486-g6456150.jar' |
Contributor
There was a problem hiding this comment.
I just created ibi-group/datatools-server#237. I think it would be better not to pin the version to a commit for the e2e test.
landonreed
approved these changes
Sep 24, 2019
Contributor
landonreed
left a comment
landonreed
left a comment
There was a problem hiding this comment.
Looks good, but let's get ibi-group/datatools-server#237 merged in before merging this one in.
Codecov Report
@@ Coverage Diff @@
## dev #489 +/- ##
==========================================
+ Coverage 16.27% 16.34% +0.06%
==========================================
Files 309 309
Lines 15308 15317 +9
Branches 4666 4668 +2
==========================================
+ Hits 2492 2503 +11
+ Misses 10954 10952 -2
Partials 1862 1862
Continue to review full report at Codecov.
|
Contributor
|
🎉 This PR is included in version 4.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
amy-corson-ibigroup
added a commit
that referenced
this pull request
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
This PR fixes a few things in order to get the e2e tests passing on Travis again.