Correctly show all modes in ServicePerModeChart

[evansiroky]

Checklist

• Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
• Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
• The description lists all applicable issues this PR seeks to resolve
• The description lists any configuration setting(s) that differ from the default settings
• All tests and CI builds passing

Description

fixes #610

[codecov-commenter]

Codecov Report

Merging #611 into dev will decrease coverage by 27.79%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##              dev     #611       +/-   ##
===========================================
- Coverage   43.46%   15.67%   -27.80%     
===========================================
  Files         323      323               
  Lines       17603    16421     -1182     
  Branches     5368     4989      -379     
===========================================
- Hits         7652     2574     -5078     
- Misses       8676    11830     +3154     
- Partials     1275     2017      +742     

Flag	Coverage Δ
#end_to_end_tests	?
#unit_tests	15.67% <0.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...nager/components/validation/ServicePerModeChart.js	0.00% <0.00%> (-78.27%)	⬇️
lib/manager/components/validation/TripsChart.js	0.00% <0.00%> (-80.40%)	⬇️
lib/manager/components/HomeProjectDropdown.js	0.00% <0.00%> (-75.76%)	⬇️
lib/common/util/map-keys.js	25.00% <0.00%> (-75.00%)	⬇️
lib/editor/util/objects.js	14.89% <0.00%> (-72.35%)	⬇️
lib/editor/components/map/TextPath.js	0.00% <0.00%> (-70.00%)	⬇️
...b/manager/containers/ActiveFeedVersionNavigator.js	0.00% <0.00%> (-70.00%)	⬇️
lib/editor/components/timetable/HeaderCell.js	0.00% <0.00%> (-68.97%)	⬇️
lib/manager/components/DeploymentPreviewButton.js	15.78% <0.00%> (-68.43%)	⬇️
lib/editor/components/EditorSidebar.js	0.00% <0.00%> (-66.67%)	⬇️
... and 267 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 872d61d...67fd8bc. Read the comment docs.

[landonreed]

Why not just do this check for modes with value > 0 in the filter below after the this._getData call? The way it currently is feels a little obfuscated. Alternatively, if you decide to keep it this way, the modes key could use a more descriptive name e.g., modesWithData or something.

[evansiroky]

I ended up doing the check in the filter as you recommended.

[landonreed]

Looks good, just a few non-blocking comments on code style.