Skip to content

on() should consistently report ESC key as "Escape" #439

@wkeese

Description

@wkeese

On Firefox delite/on reports the ESC key as "Escape", but on Chrome it's reported as "Esc". This leads to various issues such as popups not closing correctly. I think in the past everyone reported it as "Esc" but according to https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/key (and IIUC https://www.w3.org/TR/uievents/#fixed-virtual-key-codes) it should be reported as "Escape".

See delite/tests/functional/HasDropDown.html or deliteful/samples/Combobox.js. Tab to the "show menu - ltr" button (or the Combobox), press the down arrow, and then press ESC. The dropdown should close. It works on Chrome, but not on Firefox.

There's actually a functional test to make sure this works, in deliteful/tests/functional/Combobox.js:

// Similar to native select, ESCAPE also closes and validates the popup
.pressKeys(keys.ESCAPE)

I guess either it's currently failing on firefox, or it's not getting run on firefox.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions