[patch] Support Artifactory proxies on FYRE #1305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanBoden
requested review from
andrercm,
durera,
terenceq and
whitfiea
as code owners
durera
approved these changes
May 20, 2024
durera
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a cluster has been provisioned in fyre we want to use the relevant proxy address for artifactory rather than using the public one. This requires adding the proxy addresses into the entitlement secrets along with the public one. At the time of install it's not possible to know which site the cluster is in (we could determine if in fyre based on the cluster url but it doesn't include the site) so we add the proxies at all times when we add the public artifactory url.