[patch] Switch Prometheus SA token creation from oc cli to ansible module #1495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delgon
requested review from
JonahLuckett,
alequint,
andrercm,
durera,
leo-miran,
sanjayprab,
terenceq and
whitfiea
as code owners
twhart
approved these changes
Oct 8, 2024
|
Looks good to me, I ran and tested everything and it works. Looks like creating the secret is also a better way to manage the expiry times on the tokens |
whitfiea
changed the title
whitfiea
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order not to use the 'oc cli'. We switch the creation of the token of the prometheus service account via the creation of a dedicated secret and we retrieve it via the ansible k8s_info module.
Since Openshit 4.16, the creation of an SA no longer automatically generates a token. So we have to create it.