-
Notifications
You must be signed in to change notification settings - Fork 97
[patch] Fix usage of MASBR_BACKUP_DATA for mongo and db2 backup #1496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitfiea
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
karol-czarnecki
added a commit
that referenced
this pull request
Oct 7, 2024
commit a14b5b4 Author: stonepd <stonepd@uk.ibm.com> Date: Thu Oct 3 17:11:30 2024 +0100 [patch] fixes for CPD 5 edge cases and race conditions (#1501) commit c39c254 Author: stonepd <stonepd@uk.ibm.com> Date: Thu Oct 3 09:45:12 2024 +0100 [patch] CPD5 - install Python 3.10 runtime for Watson Studio (#1500) commit e7faadf Author: Witold Wierzchowski <118370754+witekwww@users.noreply.github.com> Date: Thu Oct 3 06:02:36 2024 +0200 [patch] Add variable for vargraphic setting for Manage and Health (#1427) Co-authored-by: Witold Wierzchowski <witold.wierzchowski@cohesivegroup.com> commit ca4d333 Author: stonepd <stonepd@uk.ibm.com> Date: Tue Oct 1 18:46:11 2024 +0100 [patch] update expired zenmetastore-edb license (#1497) commit d3e3eb4 Author: Rawa <61942902+rawa-resul@users.noreply.github.com> Date: Tue Oct 1 16:25:56 2024 +0100 [patch] Fix usage of MASBR_BACKUP_DATA for mongo and db2 backup (#1496) Co-authored-by: Rawa Resul <rawa.resul@ibm.com> commit 672daca Author: André Marcelino <31037381+andrercm@users.noreply.github.com> Date: Tue Oct 1 11:00:09 2024 -0300 [patch] Allow specifying CERT_MANAGER_NAMESPACE in suite_dns (#1476) commit 7cef1f9 Author: Alona Varshal <thirdwave72@gmail.com> Date: Tue Oct 1 02:13:31 2024 -0500 [patch] Update block vs file storageclass in oneclick_core readme (#1494) commit 507ec66 Author: Eric Klingelberger <3905155+cuddlyporcupine@users.noreply.github.com> Date: Mon Sep 30 03:14:35 2024 -0500 [patch] updates to mongodb grafana v5 dashboard (#1491) Co-authored-by: Eric Klingelberger <klingelb@us.ibm.com> Co-authored-by: Andrew Whitfield <whitfiea@uk.ibm.com> commit 8fd6bc7 Author: Benjamin Xue <zxue@microsoft.com> Date: Mon Sep 30 03:06:20 2024 -0500 [patch] Add AIbroker public cert (#1432) commit 655da76 Author: Tremaine Hart <twhart@us.ibm.com> Date: Thu Sep 26 15:10:24 2024 -0500 [patch] [MASCORE-3990] Mongo v7 upgrade wipes existing stateful set cpu/memory requests/limits (#1490) commit b0be83e Author: Tremaine Hart <twhart@us.ibm.com> Date: Wed Sep 25 08:15:25 2024 -0500 [patch] use apiVersion instead of api in grafana role (#1479) Co-authored-by: JonahLuckett <51744616+JonahLuckett@users.noreply.github.com> commit f2e3e74 Author: Aymen-Ben-S <107580002+Aymen-Ben-S@users.noreply.github.com> Date: Wed Sep 25 09:11:51 2024 -0400 [patch] Bump secret creation earlier in Turbonomic role (#1487) commit 35b4af7 Author: karol-czarnecki <112193189+karol-czarnecki@users.noreply.github.com> Date: Tue Sep 24 17:13:55 2024 +0100 [patch] add support for default storage classes in techzone clusters (#1481) Co-authored-by: karol-czarnecki <karol.czarnecki@ie.ibm/com> commit 4bca03f Author: Terence Quinn <quinnt@us.ibm.com> Date: Tue Sep 24 11:12:42 2024 -0500 [patch] allow setting of PLAIN authentication for MongoDB (#1486) commit 12e101f Author: Tremaine Hart <twhart@us.ibm.com> Date: Thu Sep 19 11:02:36 2024 -0500 [patch] forgot to add rbac rules for grafana v5 (#1478) commit b8d545d Author: Harsh Tamakuwala <31183552+harsh42774@users.noreply.github.com> Date: Thu Sep 19 20:07:43 2024 +0530 [patch] Fix namespace lookup when cert provider is ibm (#1477) Co-authored-by: Harsh Tamakuwala <Harsh.Tamakuwala@ibm.com> commit 6b0385f Author: Tremaine Hart <twhart@us.ibm.com> Date: Wed Sep 18 09:50:52 2024 -0500 [patch] fix nfs for manage and health (#1474) commit b1630e9 Author: Tremaine Hart <twhart@us.ibm.com> Date: Tue Sep 17 10:22:05 2024 -0500 [patch] [MASCORE-3733] grafana dashboard not working after upgrade openshift to v4.15 (#1472) commit fdee49c Author: stonepd <stonepd@uk.ibm.com> Date: Tue Sep 17 10:00:18 2024 +0100 [patch] wait for subscription to complete when creating (#1471) commit 901c12a Author: chiragcsatani <157094209+chiragcsatani@users.noreply.github.com> Date: Mon Sep 16 10:50:53 2024 +0530 Revert "[patch] debug statement for cos hmac" (#1470) commit 774be6e Author: leo-miran <105313348+leo-miran@users.noreply.github.com> Date: Fri Sep 13 15:00:25 2024 -0300 [patch] debug statement for cos hmac (#1469) Co-authored-by: Chirag Satani <ChiragSatani@ibm.com> commit 5803215 Author: Alexandre Quinteiro <alefq0@gmail.com> Date: Thu Sep 12 23:36:07 2024 -0300 [patch] Add cos prefix in use_hmac parameter (#1467) Co-authored-by: Alexandre Quinteiro <alequint@Alexandres-MBP.lan> commit 8f367c3 Author: David Parker <parkerda@uk.ibm.com> Date: Thu Sep 12 16:16:20 2024 +0100 [patch] Fix NFS idempotency checks (#1466) commit d676162 Author: stonepd <stonepd@uk.ibm.com> Date: Thu Sep 12 11:45:45 2024 +0100 [patch] apply kubernetes changes server side to avoid version conflicts (#1465) Co-authored-by: JonahLuckett <51744616+JonahLuckett@users.noreply.github.com> commit e353afd Author: Tremaine Hart <twhart@us.ibm.com> Date: Wed Sep 11 09:18:17 2024 -0500 [patch] move mongo image to ubi8 (#1464) commit 38e110a Author: David Parker <parkerda@uk.ibm.com> Date: Wed Sep 11 09:39:23 2024 +0100 [patch] Fix "IBM License Key Center" link in docs commit d43185f Author: Ian Boden <82514609+IanBoden@users.noreply.github.com> Date: Tue Sep 10 12:28:07 2024 +0100 [patch] Mirror correct build of postgresql when using odf (#1413) commit 75b25f7 Author: Ian Boden <82514609+IanBoden@users.noreply.github.com> Date: Tue Sep 10 12:26:49 2024 +0100 [patch] Change how grafana is installed to be compatible with OCP 4.16 (#1436) commit 3385693 Author: Harsh Tamakuwala <31183552+harsh42774@users.noreply.github.com> Date: Tue Sep 10 16:55:55 2024 +0530 [patch] replaces awk cmd with k8s_info in detect_cert_manager (#1455) Co-authored-by: Harsh Tamakuwala <Harsh.Tamakuwala@ibm.com> commit b221d12 Author: stonepd <stonepd@uk.ibm.com> Date: Tue Sep 10 10:43:25 2024 +0100 [patch] Revert Apply kubernetes changes server side (#1461) commit bd3189f Author: Vishal-patel-7 <142403240+Vishal-patel-7@users.noreply.github.com> Date: Tue Sep 10 08:44:45 2024 +0530 [minor] Added HMAC support for cos (#1447) Co-authored-by: Alexandre Quinteiro <alefq0@gmail.com> Co-authored-by: unnati-solanki-git <131964221+unnati-solanki-git@users.noreply.github.com> commit 7b15177 Author: stonepd <stonepd@uk.ibm.com> Date: Mon Sep 9 17:01:01 2024 +0100 [patch] apply kubernetes changes server side to avoid version conflicts (#1459) commit 8c4974d Author: Tremaine Hart <twhart@us.ibm.com> Date: Fri Sep 6 10:10:49 2024 -0500 [minor] [MASCORE-3026] implement role/tasks for new deployments of MongoDB CE v7.0 (#1452) commit 524d951 Author: David Parker <parkerda@uk.ibm.com> Date: Thu Sep 5 11:26:43 2024 +0100 [major] Remove UDS image mirroring support (#1451)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When you export
MASBR_BACKUP_DATA
then it would fail the backup/restore tasks if the given value(s) are not a supported yaml file. Mongo and DB2 only support database so these should not be usingMASBR_BACKUP_DATA
at least until we add more features. And MAS Core and other apps should skip the value(s) inMASBR_BACKUP_DATA
that are not found/supported. It's up to the user to define these values correctly.Related issues
Testing