Skip to content

Uniquename #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2018
Merged

Uniquename #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07c7c4a
Heuristic for metric names was creating duplicates
ibmmqmet Oct 23, 2018
ba0304f
Update CHANGELOG
ibmmqmet Oct 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
# Changelog

## October 2018
* Corrected heuristic for generating metric names

## August 2018
* Added V9.1 constant definitions
* Updated build comments
Expand Down
10 changes: 8 additions & 2 deletions mqmetric/discover.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,8 +681,14 @@ func formatDescription(elem *MonElement) string {
} else if strings.Contains(s, "log_") {
/* Weird case where the log datatype is not MB or GB but should be bytes */
s = s + "_bytes"
} else {
s = s + "_count"
}

// There are some metrics that have both "count" and "byte count" in
// the descriptions. They were getting mapped to the same string, so
// we have to ensure uniqueness. We do not put "_count" on the
// metric name.
if (strings.Contains(elem.Description,"byte count")) {
s = s + "_bytes"
}
}

Expand Down