Move OCC poll processing to occ_control #4
Conversation
This is so we can make changes to the OCC poll response without kernel updates. Signed-off-by: Sheldon Bailey <baileysh@us.ibm.com>
occ_manager.cpp
Outdated
| setSensorValueToNaN(instance); | ||
| for (auto& obj : statusObjects) | ||
| { | ||
| // int instance = obj->getOccInstanceID(); |
There was a problem hiding this comment.
This loop is setting all OCCs sensors to NAN vs just the single instance that went away. I assume you need to add the check that was in the function you removed.
occ_status.cpp
Outdated
| { | ||
| for (const auto& [sensorPath, occId] : existingSensors) | ||
| { | ||
| if (occId == instance) |
There was a problem hiding this comment.
Isn't the sensors stored in the status object (meaning you don't need to check the instance ID)?
They used to all be in the manager, but I assume they could move to status object (since I dont think any are shared between occs)
occ_status.hpp
Outdated
| return device.master(); | ||
| } | ||
|
|
||
| /** @brief Read OCC state (will trigger kernel to poll the OCC) */ |
| capHardMin = PollRspHardMin; | ||
| capMax = PollRspMaxPower; | ||
|
|
||
| return parmsChanged; |
There was a problem hiding this comment.
Add a comment that this function is only called once when the master OCC goes active so it always returns that the parms have changed. (could get rid of the parmsChanged var as well)
This is so we can make changes to the OCC poll response without kernel updates. Signed-off-by: Sheldon Bailey <baileysh@us.ibm.com>
| obj->setSensorValueToNaN(); | ||
| if (instance == obj->getOccInstanceID()) | ||
| { | ||
| obj->setSensorValueToNaN(); |
There was a problem hiding this comment.
You could break out since there is only a single instance
| return; | ||
| }//end Kernel HandlePollAction | ||
|
|
||
| <<<<<<< HEAD |
| } //end OCCC pollReadPcapBounds | ||
|
|
||
|
|
||
| #else |
There was a problem hiding this comment.
Maybe you could put these in 2 different files? It is kind of confusing with both functions in the same file (when searching, etc)
maybe occ_poll_handler_kernel.cpp ???
Did you give up on having a poll handler base class, and then have app / kernel objects? or this is just first step?
Class OccPollHandler
{
common vars/functions
}
Class AppPoll : public OccPollHandler
{
app poll specific vars/functions
}
Class KernelPoll : public OccPollHandler
{
kernel poll specific vars/functions
}
// Then use with:
OccPollHandler *pollHandler;
if (kernel)
{
KernelPoll kPoll;
pollHandler = &kPoll;
}
else
{
AppPoll aPoll;
pollHandler = &aPoll;
}
pollHandler->pollReadStateStatus();
...
2 participants
This moves the OCC poll from kernel to the occ-control app for more flexability.