merge changes #123
merge changes #123
Conversation
![ibm-mend-app[bot]](https://avatars.githubusercontent.com/u/133279236?s=60&v=4){kind=small}
| <label className="block text-sm font-medium text-gray-700 mb-2"> | ||
| Version Description | ||
| </label> | ||
| <textarea |
There was a problem hiding this comment.
Mend Code Security Check
New finding (1 of 10)
The Mend Code Security Check of your branch failed because of a DOM Based Cross-Site Scripting finding in this line.
| Severity | Vulnerability Type | CWE | File | Data Flows | Detected |
|---|---|---|---|---|---|
 High | DOM Based Cross-Site Scripting | 1 | 2025-09-15 08:49pm | ||
| |||||
| <label className="block text-sm font-medium mb-2"> | ||
| Version Description | ||
| </label> | ||
| <textarea |
There was a problem hiding this comment.
Mend Code Security Check
New finding (2 of 10)
The Mend Code Security Check of your branch failed because of a DOM Based Cross-Site Scripting finding in this line.
| Severity | Vulnerability Type | CWE | File | Data Flows | Detected |
|---|---|---|---|---|---|
| High | DOM Based Cross-Site Scripting | 1 | 2025-09-15 08:49pm | ||
| |||||
| <label className="block text-sm font-medium mb-2"> | ||
| Draft Name | ||
| </label> | ||
| <Input |
There was a problem hiding this comment.
Mend Code Security Check
New finding (3 of 10)
The Mend Code Security Check of your branch failed because of a DOM Based Cross-Site Scripting finding in this line.
| Severity | Vulnerability Type | CWE | File | Data Flows | Detected |
|---|---|---|---|---|---|
| High | DOM Based Cross-Site Scripting | 1 | 2025-09-15 08:49pm | ||
| |||||
| <label className="block text-sm font-medium text-gray-700 mb-2"> | ||
| Version Number | ||
| </label> | ||
| <input |
There was a problem hiding this comment.
Mend Code Security Check
New finding (4 of 10)
The Mend Code Security Check of your branch failed because of a DOM Based Cross-Site Scripting finding in this line.
| Severity | Vulnerability Type | CWE | File | Data Flows | Detected |
|---|---|---|---|---|---|
| High | DOM Based Cross-Site Scripting | 1 | 2025-09-15 08:49pm | ||
| |||||
| Custom Version (e.g.,{" "} | ||
| {isDraft ? "1.0.0-rc1" : "1.0.0"}) | ||
| </label> | ||
| <input |
There was a problem hiding this comment.
Mend Code Security Check
New finding (5 of 10)
The Mend Code Security Check of your branch failed because of a DOM Based Cross-Site Scripting finding in this line.
| Severity | Vulnerability Type | CWE | File | Data Flows | Detected |
|---|---|---|---|---|---|
| High | DOM Based Cross-Site Scripting | 1 | 2025-09-15 08:49pm | ||
| |||||
| <div className="mb-6 flex flex-col sm:flex-row gap-4 items-center justify-between"> | ||
| <div className="relative flex-1 max-w-sm"> | ||
| <Search className="absolute left-3 top-1/2 transform -translate-y-1/2 h-4 w-4 text-gray-400" /> | ||
| <input |
There was a problem hiding this comment.
Mend Code Security Check
New finding (6 of 10)
The Mend Code Security Check of your branch failed because of a DOM Based Cross-Site Scripting finding in this line.
| Severity | Vulnerability Type | CWE | File | Data Flows | Detected |
|---|---|---|---|---|---|
| High | DOM Based Cross-Site Scripting | 1 | 2025-09-15 08:49pm | ||
| |||||
| await this.questionService.updateQuestionGradingContext(assignmentId); | ||
| } | ||
|
|
||
| await this.assignmentRepository.update(assignmentId, { |
There was a problem hiding this comment.
Mend Code Security Check
New finding (9 of 10)
The Mend Code Security Check of your branch failed because of a NoSQL Injection finding in this line.
| Severity | Vulnerability Type | CWE | File | Data Flows | Detected |
|---|---|---|---|---|---|
| High | NoSQL Injection | 2 | 2025-09-15 08:49pm | ||
| |||||
| } | ||
|
|
||
| if (cached) { | ||
| this.insightsCache.delete(cacheKey); |
There was a problem hiding this comment.
Mend Code Security Check
New finding (10 of 10)
The Mend Code Security Check of your branch failed because of a Server Side Request Forgery finding in this line.
| Severity | Vulnerability Type | CWE | File | Data Flows | Detected |
|---|---|---|---|---|---|
| High | Server Side Request Forgery | 1 | 2025-09-15 08:49pm | ||
| |||||
* fix variation generation for true false question types with a nicer refactor * adding local github client id/secret * feat: Implement soft deletion for question variants, improve publishing workflow, and fix UI bugs - Added soft deletion for question variants to retain them in learner attempts when deleted. - Refactored the publishing workflow to: - Record assignment overview and configuration in the database when "Save & Publish" is pressed. - Reduce the number of API calls for improved efficiency and clarity. - Fixed bugs including: - Proper display of bullet points and ordered lists as set by the author. - Disabling the "Save & Publish" button when no changes are detected in the assignment. * fileupload-bug-fix * refactor: Update useFilteredAssignmentConfig to include questions This commit updates the useFilteredAssignmentConfig function in the filterAssignmentConfig.ts file. It adds the 'questions' property to the destructured object from the useAuthorStore hook. This change ensures that the 'questions' property is included in the returned ReplaceAssignmentRequest object. Ref: #123 * refactor: Update ReplaceAssignmentRequest to make questions optional * fixing report type issue with OTHER * refactor: Update fetchRepoContents to handle errors and set owner name - Refactored the fetchRepoContents function in GithubUploadModal.tsx to handle errors when fetching repository contents and set the owner name correctly. - Added error handling for failed repository content loading. * fix tool tip positioning * Mark language integration (#756) * fix ugly scrollbars by removing them haha * new mark translation feature * Add translation capability to AI usage type enum * Refactor language integration and translation logic * it checks over the assignment configuration and intro before enabling the submit button * remove console.log * Refactor TipsView and QuestionPage components so that if the version matches, it shows the tips. If the learner chose to not see it again, it will be toggled off until a new version is out * fix github organization file save bug * making learner side responsive * fix name issue
* fix variation generation for true false question types with a nicer refactor * adding local github client id/secret * feat: Implement soft deletion for question variants, improve publishing workflow, and fix UI bugs - Added soft deletion for question variants to retain them in learner attempts when deleted. - Refactored the publishing workflow to: - Record assignment overview and configuration in the database when "Save & Publish" is pressed. - Reduce the number of API calls for improved efficiency and clarity. - Fixed bugs including: - Proper display of bullet points and ordered lists as set by the author. - Disabling the "Save & Publish" button when no changes are detected in the assignment. * fileupload-bug-fix * refactor: Update useFilteredAssignmentConfig to include questions This commit updates the useFilteredAssignmentConfig function in the filterAssignmentConfig.ts file. It adds the 'questions' property to the destructured object from the useAuthorStore hook. This change ensures that the 'questions' property is included in the returned ReplaceAssignmentRequest object. Ref: #123 * refactor: Update ReplaceAssignmentRequest to make questions optional * fixing report type issue with OTHER * refactor: Update fetchRepoContents to handle errors and set owner name - Refactored the fetchRepoContents function in GithubUploadModal.tsx to handle errors when fetching repository contents and set the owner name correctly. - Added error handling for failed repository content loading. * fix tool tip positioning * Mark language integration (#756) * fix ugly scrollbars by removing them haha * new mark translation feature * Add translation capability to AI usage type enum * Refactor language integration and translation logic * it checks over the assignment configuration and intro before enabling the submit button * remove console.log * initial attempt of fully translating assignments * fully translated assignment version 1 * linting * fix bugs with variants * linting and formating * some final touches with tiny bug fixes and ui adjustments. Fixed the way progress bar looks and the percentage it gets to make it linear * fix tests * fix submit button * refactor(api): improve error handling and agent selection in ApiService * linting and fixing some minor bugs * minor adjustments to ensure that older assignments with no language translation is not broken * file name change * change file name (#870) * update yarn.lock * commenting not so useful code and fix a build issue with jwt.cookie.strategy * Install build dependencies required to compile native modules. * Install build dependencies required to compile native modules. * restoring back old jwt cookie strat * restoring back old jwt cookie strat * restoring back old jwt cookie strat * small patch * Refactor API controller to use UserSessionRequest instead of Request for handling API requests * Refactor ApiService constructor and methods * Refactor ApiService constructor and methods * Refactor ApiService constructor and methods * Refactor AuthFetchToAbout component to improve data fetching and decoding This commit refactors the AuthFetchToAbout component in the learner/[assignmentId] directory. It improves the data fetching process by using async/await and Promise.all to fetch assignment and attempts data. It also adds decoding of assignment fields to handle special characters and improve readability. * Refactor ApiController and ApiService to work on skills network platform (test) * testing out this change * Refactor ApiController and ApiService to improve logging and error handling * Refactor ApiController and ApiService to improve logging and error handling * fix problems with publishing assignments * some bug fixes with publishing and translating the assignments and its questions * Authors are not required to pick languages as they should be testing the assignment using the original language that they wrote
1 participant
PR Description
Overview:
Type of Issue:
feat): New functionality or feature added.bug): Issue or bug resolved.chore): Maintenance, refactoring, or non-functional changes.doc): Documentation improvements or additions.Change Type:
Testing & Validation:
Purpose:
Context:
Basic Usage:
Notes to Reviewer: