Skip to content

feat: enhance config #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Aug 6, 2021
Merged

feat: enhance config #49

merged 22 commits into from
Aug 6, 2021

Conversation

@ClarkXia
Copy link
Collaborator

@ClarkXia ClarkXia commented Jul 27, 2021 •
edited
Loading

SoloJiang
SoloJiang reviewed Jul 28, 2021
View reviewed changes
packages/build-scripts/src/core/Context.ts
if (this.userConfig.customWebpack) {
hijackWebpackResolve(this.webpack, this.rootDir);
}
this.checkPluginValue(builtInPlugins); // check plugins property
Copy link
Collaborator

@SoloJiang SoloJiang Jul 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注释是不是加代码上面更好点

@delete-merged-branch delete-merged-branch bot deleted the branch release-next August 6, 2021 08:24
@ClarkXia ClarkXia changed the base branch from refactor-context to release-next August 6, 2021 08:24
@ClarkXia ClarkXia merged commit e8f5081 into release-next Aug 6, 2021
@delete-merged-branch delete-merged-branch bot deleted the feat-enhance-config branch August 6, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SoloJiang SoloJiang SoloJiang approved these changes

@maoxiaoke maoxiaoke Awaiting requested review from maoxiaoke

@luhc228 luhc228 Awaiting requested review from luhc228

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ClarkXia @SoloJiang