feat: 🎸 support user config & cli option check #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
maoxiaoke
commented
Aug 16, 2021
maoxiaoke
commented
- support user config & cli option check
ClarkXia
reviewed
Aug 17, 2021
Collaborator
|
这个能力 0.x 版本和 1.x 版本应该都需要 |
ClarkXia
reviewed
Aug 19, 2021
| this.registerConfig('userConfig', args); | ||
| } | ||
|
|
||
| public hasConfigRegisterd = (type: 'userConfigRegistration' | 'cliOptionRegistration'): (name: string) => boolean => (name: string): boolean => { |
Collaborator
There was a problem hiding this comment.
type CheckRegistedConfig = (name: string) => boolean;
hasConfigRegisterd = (type: 'userConfigRegistration' | 'cliOptionRegistration'): CheckRegistedConfig是不是多了一层类型返回？
另外由于 api 比较简单，可以考虑下是不是一个函数就能承载，统一都是 cliOptions 和 userConfig 用 type 来区分
ClarkXia
approved these changes
Aug 24, 2021
ClarkXia
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.