Merged
Conversation
Member
|
Note that whitespace is significant for XML. Pretty-printing will result in documents with broken signatures, unless the signature is calculated after reformatting the nodes. |
Author
|
Indeed. Here is a better solution, using a dedicated 'indent' action, allowing to reformat before signing. |
- Replace split() / startswith() strategy with regular expression search that anchors on word boundary.
reindenting the tree before printing ensure correct indentation, whereas pretty_print just break lines.
guillomovitch
force-pushed
the
pretty-print
branch
from
a59e306 to
851fb34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows to optionally pretty-print XML output.