Skip to content

Pipeline to extract trust info from SP metadata#249

Closed
enriquepablo wants to merge 0 commit intoIdentityPython:masterfrom
enriquepablo:master
Closed

Pipeline to extract trust info from SP metadata#249
enriquepablo wants to merge 0 commit intoIdentityPython:masterfrom
enriquepablo:master

Conversation

@enriquepablo
Copy link
Contributor

All Submissions:

  • [ x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [ x] Have you added an explanation of what problem you are trying to solve with this PR?
  • [ x] Have you added information on what your changes do and why you chose this as your solution?
  • [ x] Have you written new tests for your changes?
  • [ x] Does your submission pass tests?
  • [ x] This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

@leifj leifj self-requested a review August 30, 2023 12:27
Copy link
Contributor

@leifj leifj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to talk about some of those points. I like the code overall.

return json.dumps(res)


@pipe(name='tinfojson')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason not to add this data into the discojson structure?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well the discojson contains metadata for a list of IdPs, and this contains trust info for a list of SPs... The usage then in the MDQ server is different for each list - so to put both in the same structure I think we would want a pair of separated lists

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that makes sense. Maybe we should make this really clear by having a discojson for IdPs and one for SPs because we really do need to have all the SPs available to the discovery UX anyway (displayname etc)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand - who would consume the list of SP metadata? The SA button is already in the SP login page so I wouldn't think it needs the SP md?

xsi="http://www.w3.org/2001/XMLSchema-instance",
ser="http://eidas.europa.eu/metadata/servicelist",
eidas="http://eidas.europa.eu/saml-extensions",
ti="urn:oasis:names:tc:SAML:metadata:trustinfo",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably change this to some NS related to seamlessaccess. In reality we will never be able to get this stuff published through OASIS since the SSTC shutdown. I suggest we change the NS in the spec and code to https://seamlessaccess.org/NS/trustinfo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and also sync this with @Zacharias to make sure we talk to seamlessaccess about this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants