Pipeline to extract trust info from SP metadata#249
Pipeline to extract trust info from SP metadata#249enriquepablo wants to merge 0 commit intoIdentityPython:masterfrom
Conversation
leifj
left a comment
There was a problem hiding this comment.
Need to talk about some of those points. I like the code overall.
src/pyff/builtins.py
Outdated
| return json.dumps(res) | ||
|
|
||
|
|
||
| @pipe(name='tinfojson') |
There was a problem hiding this comment.
Is there a reason not to add this data into the discojson structure?
There was a problem hiding this comment.
Well the discojson contains metadata for a list of IdPs, and this contains trust info for a list of SPs... The usage then in the MDQ server is different for each list - so to put both in the same structure I think we would want a pair of separated lists
There was a problem hiding this comment.
yeah that makes sense. Maybe we should make this really clear by having a discojson for IdPs and one for SPs because we really do need to have all the SPs available to the discovery UX anyway (displayname etc)
There was a problem hiding this comment.
I'm not sure I understand - who would consume the list of SP metadata? The SA button is already in the SP login page so I wouldn't think it needs the SP md?
src/pyff/constants.py
Outdated
| xsi="http://www.w3.org/2001/XMLSchema-instance", | ||
| ser="http://eidas.europa.eu/metadata/servicelist", | ||
| eidas="http://eidas.europa.eu/saml-extensions", | ||
| ti="urn:oasis:names:tc:SAML:metadata:trustinfo", |
There was a problem hiding this comment.
We should probably change this to some NS related to seamlessaccess. In reality we will never be able to get this stuff published through OASIS since the SSTC shutdown. I suggest we change the NS in the spec and code to https://seamlessaccess.org/NS/trustinfo
There was a problem hiding this comment.
and also sync this with @Zacharias to make sure we talk to seamlessaccess about this
6c506d5 to
f41f070
Compare
All Submissions: