Skip to content

Introducing storage interface for CDN Stored files#2360

Merged
mapkyca merged 1 commit intoidno:masterfrom
mapkyca:mapkyca-cdn-storable
Mar 10, 2019
Merged

Introducing storage interface for CDN Stored files#2360
mapkyca merged 1 commit intoidno:masterfrom
mapkyca:mapkyca-cdn-storable

Conversation

@mapkyca
Copy link
Copy Markdown
Member

@mapkyca mapkyca commented Mar 3, 2019

Here's what I fixed or added:

Added an interface to allow for CDN storable files

Here's why I did it:

To support direct URL for a file stored on a CDN (for use with IPFS etc)

Refs #2322

Checklist:

  • This pull request addresses a single issue
  • If this code includes interface changes, I've included screenshots in this Pull Request thread
  • I've adhered to Known's style guide
  • My git branch is named in a descriptive way - i.e., yourname-summary-of-issue
  • I've tested my code in-browser
  • My code contains descriptive comments
  • I've added tests where applicable

@mapkyca mapkyca requested a review from benwerd as a code owner March 3, 2019 18:48
@mapkyca mapkyca merged commit ffca3d7 into idno:master Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants