Kk/#1139 rtd page for available converters to and from psdm #1432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-peter
requested changes
Sep 5, 2025
Member
There was a problem hiding this comment.
Looks good, thanks also for adding the descriptions.
Two things missing:
- changelog entry
- a menu entry point, so that the page can be found (this should also fix the compilation error). Adding the page to the "I/O" submenu as the last entry would fit well, I think. Also move the md file to the io directory then, please.
Member
|
Also I realized we have https://github.com/ie3-institute/pp2psdm, which you could add as well |
sebastian-peter
requested changes
Sep 11, 2025
Contributor
Author
|
I have made the requested changes. |
changes #1139
…-and-from-PSDM # Conflicts: # CHANGELOG.md
sebastian-peter
approved these changes
Oct 1, 2025
Member
sebastian-peter
left a comment
sebastian-peter
left a comment
There was a problem hiding this comment.
Made some adaptations, looks finished now
sebastian-peter
deleted the
kk/#1139-rtd-page-for-available-converters-to-and-from-PSDM
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1139