Adding processor for graphic inputs #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!test |
…-and-csv-file-sink' into ck/#73-graphicInputProcessors # Conflicts: # src/test/groovy/edu/ie3/datamodel/io/processor/ProcessorProviderTest.groovy
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
============================================
+ Coverage 60.48% 61.01% +0.52%
- Complexity 762 774 +12
============================================
Files 182 183 +1
Lines 3437 3445 +8
Branches 432 433 +1
============================================
+ Hits 2079 2102 +23
+ Misses 1226 1211 -15
Partials 132 132
Continue to review full report at Codecov.
|
johanneshiry
suggested changes
Mar 26, 2020
src/test/groovy/edu/ie3/datamodel/io/processor/input/GraphicInputProcessorTest.groovy
Show resolved
Hide resolved
|
!test |
|
!test |
johanneshiry
force-pushed
the
ck/#73-graphicInputProcessors
branch
from
ba97c55 to
04f369c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly solves #73 (introduces an
GraphicInputProcessorfor allGraphicInputentities) and is based on #74.when this one is merged, we still need processors for remaining
InputEntitys (OperatorInput,AssetCharacteristicInput-subclasses,RandomLoadParameterandAssetTypeInput- when addressing this, it might be possible to extend theAssetInputProcessorto a fullInputEntityProcessorinstead of splitting up logic to new processors)Additionally this pull request closes #82.