-
Notifications
You must be signed in to change notification settings - Fork 7
Extend processors and csv file sink #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…pted StorageStrategy for improved exception
… of bdew load profile loads
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
============================================
+ Coverage 59.84% 60.47% +0.63%
- Complexity 729 762 +33
============================================
Files 181 182 +1
Lines 3337 3436 +99
Branches 423 432 +9
============================================
+ Hits 1997 2078 +81
- Misses 1209 1226 +17
- Partials 131 132 +1
Continue to review full report at Codecov.
|
!test |
src/main/java/edu/ie3/datamodel/io/factory/input/AssetInputEntityFactory.java
Outdated
Show resolved
Hide resolved
src/test/groovy/edu/ie3/datamodel/io/processor/input/AssetInputProcessorTest.groovy
Show resolved
Hide resolved
src/test/groovy/edu/ie3/datamodel/io/processor/input/AssetInputProcessorTest.groovy
Show resolved
Hide resolved
src/test/groovy/edu/ie3/datamodel/io/processor/input/AssetInputProcessorTest.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/edu/ie3/datamodel/io/processor/input/AssetInputProcessorTest.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/edu/ie3/datamodel/io/processor/input/AssetInputProcessorTest.groovy
Outdated
Show resolved
Hide resolved
This PR closes #79. I checked thoroughly. The found mistake in complex topology actual brought a different topology then expected, but the mixed up nodes are from the same sub grid. Therefore, the tests for sub grid topology generation are correct and working. 👍 |
!test |
!test |
…tProcessorTest.groovy Co-Authored-By: Chris Kittl <44838605+ckittl@users.noreply.github.com>
…tProcessorTest.groovy Co-Authored-By: Chris Kittl <44838605+ckittl@users.noreply.github.com>
…om:ie3-institute/PowerSystemDatamodel into jh/#73-extend-processors-and-csv-file-sink
!test |
Partly solves #73 (introduces an
AssetInputProcessor
for allAssetInput
entities)when this one is merged, we still need processors for remaining
InputEntity
s (GraphicInput
,OperatorInput
,AssetCharacteristicInput
-subclasses,RandomLoadParameter
andAssetTypeInput
- when addressing this, it might be possible to extend theAssetInputProcessor
to a fullInputEntityProcessor
instead of splitting up logic to new processors)Additionally to #73 when reviewing @ckittl please carefully check for #79