Skip to content

Conversation

johanneshiry
Copy link
Member

@johanneshiry johanneshiry commented Mar 23, 2020

Partly solves #73 (introduces an AssetInputProcessor for all AssetInput entities)

when this one is merged, we still need processors for remaining InputEntitys (GraphicInput, OperatorInput, AssetCharacteristicInput-subclasses, RandomLoadParameter and AssetTypeInput - when addressing this, it might be possible to extend the AssetInputProcessor to a full InputEntityProcessor instead of splitting up logic to new processors)

Additionally to #73 when reviewing @ckittl please carefully check for #79

@johanneshiry johanneshiry added the enhancement New feature or request label Mar 23, 2020
@johanneshiry johanneshiry self-assigned this Mar 23, 2020
@codecov
Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #74 into master will increase coverage by 0.63%.
The diff coverage is 76.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #74      +/-   ##
============================================
+ Coverage     59.84%   60.47%   +0.63%     
- Complexity      729      762      +33     
============================================
  Files           181      182       +1     
  Lines          3337     3436      +99     
  Branches        423      432       +9     
============================================
+ Hits           1997     2078      +81     
- Misses         1209     1226      +17     
- Partials        131      132       +1
Impacted Files Coverage Δ Complexity Δ
...3/datamodel/io/factory/input/NodeInputFactory.java 100% <ø> (ø) 3 <0> (ø) ⬇️
...atamodel/models/input/system/type/BmTypeInput.java 46.15% <ø> (ø) 3 <0> (ø) ⬇️
...edu/ie3/datamodel/models/input/system/BmInput.java 40% <ø> (ø) 5 <0> (ø) ⬇️
...del/io/processor/result/ResultEntityProcessor.java 90.9% <ø> (+13.55%) 6 <0> (-6) ⬇️
...du/ie3/datamodel/models/input/system/ChpInput.java 40% <ø> (+8%) 5 <0> (+2) ⬆️
...u/ie3/datamodel/models/input/system/LoadInput.java 34.28% <0%> (-7.1%) 6 <0> (ø)
...java/edu/ie3/datamodel/models/BdewLoadProfile.java 64% <0%> (-36%) 3 <0> (ø)
.../ie3/datamodel/io/processor/ProcessorProvider.java 86.04% <100%> (+1.04%) 14 <0> (+1) ⬆️
...datamodel/models/input/system/StorageStrategy.java 70.58% <25%> (-14.03%) 5 <1> (+1)
...du/ie3/datamodel/io/processor/EntityProcessor.java 88.11% <86.95%> (-3.42%) 45 <27> (+26)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d68291...b123e2f. Read the comment docs.

@johanneshiry johanneshiry marked this pull request as ready for review March 25, 2020 14:39
@johanneshiry
Copy link
Member Author

!test

@ckittl
Copy link
Member

ckittl commented Mar 25, 2020

Partly solves #73 (introduces an AssetInputProcessor for all AssetInput entities)

when this one is merged, we still need processors for remaining InputEntitys (GraphicInput, OperatorInput, AssetCharacteristicInput-subclasses, RandomLoadParameter and AssetTypeInput - when addressing this, it might be possible to extend the AssetInputProcessor to a full InputEntityProcessor instead of splitting up logic to new processors)

Additionally to #73 when reviewing @ckittl please carefully check for #79

This PR closes #79. I checked thoroughly. The found mistake in complex topology actual brought a different topology then expected, but the mixed up nodes are from the same sub grid. Therefore, the tests for sub grid topology generation are correct and working. 👍

@ckittl ckittl linked an issue Mar 25, 2020 that may be closed by this pull request
@ckittl
Copy link
Member

ckittl commented Mar 25, 2020

!test

@ckittl
Copy link
Member

ckittl commented Mar 25, 2020

!test

johanneshiry and others added 5 commits March 26, 2020 08:03
…tProcessorTest.groovy

Co-Authored-By: Chris Kittl <44838605+ckittl@users.noreply.github.com>
…tProcessorTest.groovy

Co-Authored-By: Chris Kittl <44838605+ckittl@users.noreply.github.com>
…om:ie3-institute/PowerSystemDatamodel into jh/#73-extend-processors-and-csv-file-sink
@johanneshiry
Copy link
Member Author

!test

@ckittl ckittl merged commit 4995a0f into master Mar 26, 2020
@ckittl ckittl deleted the jh/#73-extend-processors-and-csv-file-sink branch March 26, 2020 08:08
@ckittl ckittl mentioned this pull request Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix not-working (?) tests using GridTestData

2 participants