Skip to content

Conversation

@sebastian-peter
Copy link
Member

@sebastian-peter sebastian-peter commented Dec 12, 2023

Resolves parts of #955

Documentation is expected to be adapted in a different PR

@sebastian-peter sebastian-peter added the model Related to the data model (conceptually, not to the implementation) label Dec 12, 2023
@sebastian-peter sebastian-peter added this to the Version 4.2 milestone Dec 12, 2023
@sebastian-peter sebastian-peter self-assigned this Dec 12, 2023
@sebastian-peter sebastian-peter marked this pull request as ready for review December 12, 2023 16:45
# Conflicts:
#	src/test/groovy/edu/ie3/datamodel/io/sink/CsvFileSinkTest.groovy
#	src/test/groovy/edu/ie3/datamodel/models/input/container/JointGridContainerTest.groovy
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielfeismann danielfeismann merged commit 2131b24 into dev Dec 13, 2023
@danielfeismann danielfeismann deleted the sp/#955-eminput-asset branch December 13, 2023 09:56
@sebastian-peter sebastian-peter modified the milestones: Version 4.2, Version 5.0 Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model Related to the data model (conceptually, not to the implementation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants