-
Notifications
You must be signed in to change notification settings - Fork 0
Reduce memory usage. #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce memory usage. #259
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
==========================================
+ Coverage 62.75% 63.42% +0.66%
==========================================
Files 70 70
Lines 2054 2097 +43
Branches 48 51 +3
==========================================
+ Hits 1289 1330 +41
- Misses 765 767 +2 ☔ View full report in Codecov by Sentry. |
danielfeismann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be a problem when converting 1-MVLV-rural-all-0-no_sw
It should not contain switches but something getting wrong there. Could you have a look, please? (Can't say if this happens in dev as well, grid conversion is still running...)
Exception in thread "main" java.lang.IllegalArgumentException: Cannot traverse along switch chain, as there is a junction included at node NodeInput{uuid=cda7d5d9-8b32-4336-827e-c570c371a3f9, id='MV1.101 Bus 63', operator=372e269a-4a75-45b1-82a6-7bc07d0cadd7, operationTime=OperationTime{startDate=null, endDate=null, isLimited=false}, vTarget=1 p.u., slack=false, geoPosition=POINT (11.3918 53.6287), voltLvl=CommonVoltageLevel{id='Mittelspannung', nominalVoltage=20 kV, synonymousIds=[Mittelspannung, ms, ms_20kv, mv, mv_20kV], voltageRange=Interval [20 kV, 30 kV)}, subnet=2}
at edu.ie3.datamodel.utils.ContainerUtils.traverseAlongSwitchChain(ContainerUtils.java:767)
at edu.ie3.datamodel.utils.ContainerUtils.traverseAlongSwitchChain(ContainerUtils.java:719)
at edu.ie3.datamodel.utils.ContainerUtils.getSubGridContainers(ContainerUtils.java:682)
at edu.ie3.datamodel.utils.ContainerUtils.buildSubGridTopologyGraph(ContainerUtils.java:581)
at edu.ie3.datamodel.utils.ContainerUtils.buildSubGridTopologyGraph(ContainerUtils.java:515)
at edu.ie3.datamodel.models.input.container.JointGridContainer.<init>(JointGridContainer.java:32)
at edu.ie3.simbench.convert.GridConverter$.convert(GridConverter.scala:91)
at edu.ie3.simbench.main.RunSimbench$.$anonfun$main$1(RunSimbench.scala:94)
at scala.collection.immutable.List.foreach(List.scala:334)
at edu.ie3.simbench.main.RunSimbench$.main(RunSimbench.scala:49)
at edu.ie3.simbench.main.RunSimbench.main(RunSimbench.scala)
src/main/scala/edu/ie3/simbench/convert/profiles/PowerProfileConverter.scala
Outdated
Show resolved
Hide resolved
I can convert the grid with this branch without a problem. The same goes for the dev branch. |
|
Interesting... I'm still getting this error. Tried it on two machines. |
|
For documentation: "-no_sw" simbench codes should still use option removeSwitches. This might be solved by #286 |
danielfeismann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #67