Skip to content

Conversation

@staudtMarius
Copy link
Member

Resolves #67

@staudtMarius staudtMarius added the bug Something isn't working label Aug 10, 2024
@staudtMarius staudtMarius self-assigned this Aug 10, 2024
@staudtMarius staudtMarius marked this pull request as ready for review August 21, 2024 10:49
@codecov
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.42%. Comparing base (60ce749) to head (bfedaf0).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
+ Coverage   62.75%   63.42%   +0.66%     
==========================================
  Files          70       70              
  Lines        2054     2097      +43     
  Branches       48       51       +3     
==========================================
+ Hits         1289     1330      +41     
- Misses        765      767       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@staudtMarius staudtMarius requested a review from jo-bao August 21, 2024 11:02
@danielfeismann danielfeismann self-requested a review November 28, 2024 13:55
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a problem when converting 1-MVLV-rural-all-0-no_sw
It should not contain switches but something getting wrong there. Could you have a look, please? (Can't say if this happens in dev as well, grid conversion is still running...)

Exception in thread "main" java.lang.IllegalArgumentException: Cannot traverse along switch chain, as there is a junction included at node NodeInput{uuid=cda7d5d9-8b32-4336-827e-c570c371a3f9, id='MV1.101 Bus 63', operator=372e269a-4a75-45b1-82a6-7bc07d0cadd7, operationTime=OperationTime{startDate=null, endDate=null, isLimited=false}, vTarget=1 p.u., slack=false, geoPosition=POINT (11.3918 53.6287), voltLvl=CommonVoltageLevel{id='Mittelspannung', nominalVoltage=20 kV, synonymousIds=[Mittelspannung, ms, ms_20kv, mv, mv_20kV], voltageRange=Interval [20 kV, 30 kV)}, subnet=2}
	at edu.ie3.datamodel.utils.ContainerUtils.traverseAlongSwitchChain(ContainerUtils.java:767)
	at edu.ie3.datamodel.utils.ContainerUtils.traverseAlongSwitchChain(ContainerUtils.java:719)
	at edu.ie3.datamodel.utils.ContainerUtils.getSubGridContainers(ContainerUtils.java:682)
	at edu.ie3.datamodel.utils.ContainerUtils.buildSubGridTopologyGraph(ContainerUtils.java:581)
	at edu.ie3.datamodel.utils.ContainerUtils.buildSubGridTopologyGraph(ContainerUtils.java:515)
	at edu.ie3.datamodel.models.input.container.JointGridContainer.<init>(JointGridContainer.java:32)
	at edu.ie3.simbench.convert.GridConverter$.convert(GridConverter.scala:91)
	at edu.ie3.simbench.main.RunSimbench$.$anonfun$main$1(RunSimbench.scala:94)
	at scala.collection.immutable.List.foreach(List.scala:334)
	at edu.ie3.simbench.main.RunSimbench$.main(RunSimbench.scala:49)
	at edu.ie3.simbench.main.RunSimbench.main(RunSimbench.scala)

@staudtMarius
Copy link
Member Author

There seems to be a problem when converting 1-MVLV-rural-all-0-no_sw It should not contain switches but something getting wrong there. Could you have a look, please? (Can't say if this happens in dev as well, grid conversion is still running...)

Exception in thread "main" java.lang.IllegalArgumentException: Cannot traverse along switch chain, as there is a junction included at node NodeInput{uuid=cda7d5d9-8b32-4336-827e-c570c371a3f9, id='MV1.101 Bus 63', operator=372e269a-4a75-45b1-82a6-7bc07d0cadd7, operationTime=OperationTime{startDate=null, endDate=null, isLimited=false}, vTarget=1 p.u., slack=false, geoPosition=POINT (11.3918 53.6287), voltLvl=CommonVoltageLevel{id='Mittelspannung', nominalVoltage=20 kV, synonymousIds=[Mittelspannung, ms, ms_20kv, mv, mv_20kV], voltageRange=Interval [20 kV, 30 kV)}, subnet=2}
	at edu.ie3.datamodel.utils.ContainerUtils.traverseAlongSwitchChain(ContainerUtils.java:767)
	at edu.ie3.datamodel.utils.ContainerUtils.traverseAlongSwitchChain(ContainerUtils.java:719)
	at edu.ie3.datamodel.utils.ContainerUtils.getSubGridContainers(ContainerUtils.java:682)
	at edu.ie3.datamodel.utils.ContainerUtils.buildSubGridTopologyGraph(ContainerUtils.java:581)
	at edu.ie3.datamodel.utils.ContainerUtils.buildSubGridTopologyGraph(ContainerUtils.java:515)
	at edu.ie3.datamodel.models.input.container.JointGridContainer.<init>(JointGridContainer.java:32)
	at edu.ie3.simbench.convert.GridConverter$.convert(GridConverter.scala:91)
	at edu.ie3.simbench.main.RunSimbench$.$anonfun$main$1(RunSimbench.scala:94)
	at scala.collection.immutable.List.foreach(List.scala:334)
	at edu.ie3.simbench.main.RunSimbench$.main(RunSimbench.scala:49)
	at edu.ie3.simbench.main.RunSimbench.main(RunSimbench.scala)

I can convert the grid with this branch without a problem. The same goes for the dev branch.

@danielfeismann
Copy link
Member

Interesting... I'm still getting this error. Tried it on two machines.

@danielfeismann
Copy link
Member

For documentation: "-no_sw" simbench codes should still use option removeSwitches. This might be solved by #286

Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielfeismann danielfeismann merged commit fc33fbf into main Jan 7, 2025
2 checks passed
@danielfeismann danielfeismann deleted the ms/#67-reduce-memory-usage branch January 7, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Address extensive memory usage

3 participants