Fix issue #179: Leader Followers Pattern #1189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge from origin java-design-patterns
fork origin master
fork origin master
merge from origin java-design-patterns
iluwatar
requested changes
Mar 22, 2020
leader-followers/src/main/java/com.iluwatar.leaderfollowers/TaskHandler.java
Outdated
Show resolved
Hide resolved
leader-followers/src/main/java/com.iluwatar.leaderfollowers/App.java
Outdated
Show resolved
Hide resolved
leader-followers/src/main/java/com.iluwatar.leaderfollowers/App.java
Outdated
Show resolved
Hide resolved
Owner
|
@npczwh thanks for the pull request. I've added a couple of comments. Please let me know when it's ready for another look. |
Contributor
Author
|
@iluwatar Thank you for your comments. I have done the required changes. The LGTM check failed with error "invalid flag: --module-path" because it configured with java8 as the default java version. Need your help to fix it. |
iluwatar
approved these changes
Mar 26, 2020
Owner
|
Thank you for the new pattern @npczwh Well done and very much appreciated 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request title
Pull request description