fix issue 1968 and correct visitor pattern code and test. #2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @xyllq999 please keep in mind that the README code needs to be updated as well |
|
Kudos, SonarCloud Quality Gate passed! |
yonatankarp
approved these changes
Sep 11, 2022
yonatankarp
reviewed
Sep 11, 2022
Contributor
yonatankarp
left a comment
yonatankarp
left a comment
There was a problem hiding this comment.
Obviously I cannot approve it, but I'll close my PR 🙈
iluwatar
approved these changes
Sep 25, 2022
Owner
|
Many thanks for implementing this improvement @xyllq999! Kudos to @yonatankarp for raising the issue and providing review help. |
Owner
|
@all-contributors please add @xyllq999 for code |
Contributor
|
I've put up a pull request to add @xyllq999! 🎉 |
Owner
|
@all-contributors please add @yonatankarp for review |
Contributor
|
@yonatankarp already contributed before to review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR helps for solving #1968
fix issue 1968 and correct visitor pattern code
Modified issue with visitor mode code, changed different method name to method reload, fixed issue1968.
Pull request description
The main modification of the method in the class is visit, which is accessed only by different parameter types, eliminating some errors and simplifying code writing, in line with the pattern requirements.