Fix Command pattern README generics #2531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Alikbra
approved these changes
May 31, 2023
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
bot
added
the
status: stale
iluwatar
approved these changes
Aug 14, 2023
Owner
|
Looks good! Thank you for the contribution 🎉 @all-contributors please add @konstantin-goldman for docs |
Contributor
|
I couldn't determine any contributions to add, did you specify any contributions? I've put up a pull request to add @konstantin-goldman! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue: #2462
This is a trivial change, it updates the README for the command pattern to include the same code as in the implementation. The current README, which uses the "Command" object in the Deque, does not make sense (nor does it compile). Tests and checkstyle pass successfully, as expected.