Skip to content

Conversation

@Regyl
Copy link
Contributor

@Regyl Regyl commented Jul 8, 2023

Implements issue #1306

@Regyl Regyl marked this pull request as draft July 9, 2023 06:02
@Regyl Regyl force-pushed the feature/optimistic-lock branch from f0631ab to 679ea49 Compare July 9, 2023 08:16
@Regyl Regyl force-pushed the feature/optimistic-lock branch from e7c65d6 to cb541ab Compare July 9, 2023 08:39
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 9, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

89.5% 89.5% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

/**
* Primary key.
*/
private long id;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5% of developers fix this issue

UnnecessarilyFullyQualified: This fully qualified name is unambiguous to the compiler if imported.


Suggested change
private long id;
Generated

❗❗ 23 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding
File Path Line Number
optimistic-offline-lock/src/main/java/com/iluwatar/model/Card.java 13
optimistic-offline-lock/src/main/java/com/iluwatar/model/Card.java 31
optimistic-offline-lock/src/main/java/com/iluwatar/model/Card.java 26
optimistic-offline-lock/src/main/java/com/iluwatar/model/Card.java 14
optimistic-offline-lock/src/main/java/com/iluwatar/service/CardUpdateService.java 12
optimistic-offline-lock/src/main/java/com/iluwatar/model/Card.java 13
optimistic-offline-lock/src/main/java/com/iluwatar/model/Card.java 36
optimistic-offline-lock/src/main/java/com/iluwatar/service/CardUpdateService.java 12
optimistic-offline-lock/src/main/java/com/iluwatar/model/Card.java 13
optimistic-offline-lock/src/main/java/com/iluwatar/model/Card.java 12

Showing 10 of 23 findings. Visit the Lift Web Console to see all.


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

@sonatype-lift
Copy link

sonatype-lift bot commented Jul 9, 2023

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/iluwatar/java-design-patterns/2551.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/iluwatar/java-design-patterns/2551.diff | git apply

Once you're satisfied, commit and push your changes in your project.

Footnotes

  1. You can preview the patch by opening the patch URL in the browser.

@Regyl Regyl marked this pull request as ready for review July 10, 2023 19:32
@stale
Copy link

stale bot commented Aug 9, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label Aug 9, 2023
@stale stale bot removed the status: stale issues and pull requests that have not had recent interaction label Aug 27, 2023
@iluwatar iluwatar merged commit 8b11e76 into iluwatar:master Aug 27, 2023
@iluwatar
Copy link
Owner

Looks good! Thank you for the new pattern 🎉

@all-contributors please add @Regyl for code

@allcontributors
Copy link
Contributor

@iluwatar

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@Regyl already contributed before to code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants