Implemenation of the Serialized Lob Pattern #2795
Conversation
…o feature/slob_design_pattern # Conflicts: # slob/src/main/java/com/iluwatar/slob/lob/Plant.java # slob/src/main/java/com/iluwatar/slob/lob/Product.java # slob/src/main/java/com/iluwatar/slob/serializers/ClobSerializer.java
…o feature/slob_design_pattern
…_pattern # Conflicts: # pom.xml
|
Hi @iluwatar completed the implemntation for slob, can you please review this PR. |
slob/README.md
Outdated
| import static com.iluwatar.slob.lob.Animal.iterateXmlForAnimalAndPlants; | ||
|
|
||
| import java.io.Serializable; | ||
| import java.util.HashSet; | ||
| import java.util.Set; | ||
| import javax.xml.parsers.DocumentBuilderFactory; | ||
| import javax.xml.parsers.ParserConfigurationException; | ||
| import lombok.AllArgsConstructor; | ||
| import lombok.Data; | ||
| import lombok.NoArgsConstructor; | ||
| import org.w3c.dom.Document; | ||
| import org.w3c.dom.Element; | ||
| import org.w3c.dom.NodeList; |
There was a problem hiding this comment.
The code snippets included in the README.md should be minimal. We don't want to include irrelevant parts of the code, just the things needed to explain the pattern. See the other patterns for examples of how to do this.
There was a problem hiding this comment.
Got it, removed import statmenets and license doc from README.md. Kindly check now
iluwatar
left a comment
iluwatar
left a comment
There was a problem hiding this comment.
Noticed that the pattern has not been added to the parent pom.xml, so it is not built by the CI.
|
|
Looks good! Thank you for the contribution 🎉 @all-contributors please add @KishalayP for code |
|
I couldn't determine any contributions to add, did you specify any contributions? I've put up a pull request to add @KishalayP! 🎉 |
|
Thank You @iluwatar .
|
|
I couldn't determine any contributions to add, did you specify any contributions? @KishalayP already contributed before to code |
3 participants
Pull request title
Pull request description