Skip to content

Conversation

@junhkang
Copy link
Contributor

#2827

  • add page-controller module on parent pom.xml
  • add artifact information on page-controller pom.xml
  • add Springboot3, proper test dependencies on page-controller pom.xml

@junhkang junhkang marked this pull request as draft March 28, 2024 01:40
@junhkang
Copy link
Contributor Author

[Draft]
Tests Passed, but I will request new PR after my previous PR is merged

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@junhkang junhkang marked this pull request as ready for review March 30, 2024 10:40
@junhkang
Copy link
Contributor Author

@iluwatar not sure this is passed or not, let me know if I have something to change. Thank you

@iluwatar iluwatar merged commit 8471c93 into iluwatar:master Mar 30, 2024
@iluwatar
Copy link
Owner

This looks good, thanks @junhkang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants