#2852: MaverickWingman #2864
Merged
#2852: MaverickWingman #2864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hey @iluwatar, Help me with this thing also. Thankyou! 
|
Owner
|
The code style does not follow the google style that we use. See https://github.com/iluwatar/java-design-patterns/wiki/12.-IDE-instructions You can run the checkstyle checks using IDE plugin or using the command line (mvn validate). |
iluwatar
requested changes
Mar 29, 2024
.github/dependabot.yml
Outdated
Comment on lines
12
to
28
| <<<<<<< Updated upstream | ||
| ======= | ||
| allow: | ||
| - dependency-name: "org.springframework.boot:spring-boot-dependencies" | ||
| - dependency-name: "commons-dbcp:commons-dbcp" | ||
| - dependency-name: "org.htmlunit.:htmlunit" | ||
| - dependency-name: "com.google.code.gson:gson" | ||
| - dependency-name: "com.google.inject:guice" | ||
| - dependency-name: "com.github.stefanbirkner:system-lambda" | ||
| - dependency-name: "org.apache.maven.plugins:maven-surefire-plugin" | ||
| - dependency-name: "org.apache.maven.plugins:maven-assembly-plugin" | ||
| - dependency-name: "org.sonarsource.scanner.maven:sonar-maven-plugin" | ||
| - dependency-name: "org.apache.maven.plugins:maven-checkstyle-plugin" | ||
| - dependency-name: "com.mycila:license-maven-plugin" | ||
| - dependency-name: "org.jacoco:jacoco-maven-plugin" | ||
| - dependency-name: "com.iluwatar.urm:urm-maven-plugin" | ||
| >>>>>>> Stashed changes |
|
iluwatar
approved these changes
Mar 29, 2024
Owner
|
Looks good! Thank you for the contribution 🎉 @all-contributors please add @MaverickWingman for code |
Contributor
|
I couldn't determine any contributions to add, did you specify any contributions? I've put up a pull request to add @MaverickWingman! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request title
Pull request description
adjust maven group id to org.htmlunit
org.htmlunit
htmlunit
3.11.0
Replace all usages of com.gargoylesoftware.htmlunit by org.htmlunit.
Replace all usages of net.sourceforge.htmlunit by org.htmlunit.
a. import org.htmlunit.BrowserVersion;
b. import org.htmlunit.WebClient;
c. import org.htmlunit.html.HtmlInput;
d. import org.htmlunit.html.HtmlPage;
Reference: https://htmlunit.sourceforge.io/