Money pattern #3109
Merged
Money pattern #3109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the implementation of the money patter and the tests along with the read me file
iluwatar
requested changes
Dec 8, 2024
Owner
iluwatar
left a comment
iluwatar
left a comment
There was a problem hiding this comment.
In addition, add App.java or similar that demonstrates usage of Money class
Co-authored-by: Ilkka Seppälä <iluwatar@users.noreply.github.com>
Contributor
Author
|
Thank you for your feedback, I added the App.java file and changed all the issues you pointed out. |
iluwatar
previously approved these changes
Jan 6, 2025
Owner
|
Looks good! Thank you for the contribution 🎉 @all-contributors please add @Ahmed-Taha-981 for code |
Contributor
|
I've put up a pull request to add @Ahmed-Taha-981! 🎉 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the implementation of the money pattern and the tests along with the read me file
Close #1305